Build and publish Docker images to DockerHub#54
Merged
HealthyPear merged 13 commits intomasterfrom Mar 1, 2022
Merged
Conversation
HealthyPear
added
enhancement
3 tasks
- fix actions versions - change behaviour to latest release to only release - update secrets names
kosack
approved these changes
Mar 1, 2022
Collaborator
kosack
left a comment
kosack
left a comment
There was a problem hiding this comment.
for info: RockyLinux is now a drop-in replacement for the old CentOS which no longer has fixed releases. However, I think going with Fedora here is fine (but using fedora-latest could cause it to break in the future, so might want to fix it to a version). That can come later though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description
This pull request adds 2 workflows for the protopipe+interface environments (1 for the development versions and 1 with the latest releases) for building Docker images using the Dockerfiles stored in the repo and pushing them to DockerHub.
The development version is created anytime a new PR is merged or something is pushed on master, while the latest release version is only produced when a new release is published (a tag
latestand a tag with the name of the release - usually the semantic version - will be created).The development version is basically just a Fedora + a conda/mamba-base environment, since for development purposes I expect the user (developer) to bind-mount it's own cloned repositories (which contain the conda recipes).
Caveats
This is the first time I do it, so it might not work and require testing.
Documentation will be updated afterward when I am sure it works.