Create Italian Resource-Hints

[chefleo]

Makes progress on #585

[tunetheweb]

Thanks for this @chefleo but as mentioned previously we can't merge this until we have the base templates translated into Italian too:

• en/base.html
• en/base_chapter.html
• en/error.html
• en/2020/base.html
• en/2020/index.html
• en/2020/table_of_contents.html

Most of these are very small and just contain phrases used to build the site, though the first one is larger.

Also made some other suggestions below. Will do a more thorough review when they are addressed.

[Zizzamia]

Btw before merging let's have also @giopunt review 😁

[tunetheweb]

Converting to Draft as not ready to be merged until we have base templates translated too.

[tunetheweb]

A few more things I spotted preventing the chapter from generating

[tunetheweb]

Woo hoo! It's now generating the chapter.

Did a thorough review and made some comments. Hopefully most are very quick to fix.

Thanks for working on all this! Will make future chapters a lot easier!

[Zizzamia]

Ciao @bazzadp, I heard from @giopunt that he wasn't able to comment or review this PR. Is it possible because he is not part of the HTTPArchive org?

[tunetheweb]

Ciao @bazzadp, I heard from @giopunt that he wasn't able to comment or review this PR. Is it possible because he is not part of the HTTPArchive org?

Probably. Just invited him there. We should add his profile to 2020.json as well if he makes a contribution so he is credited on our contributor page.

[tunetheweb]

A couple of new attributes we recently added that need to be in the base templates and are causing the build to fail without them.

[tunetheweb]

@chefleo I pointed out some more comments above that were unresolved. They were hidden under this "Load More..." button so you may have missed them:

Once you resolve those, and that last one I added there no to revert the lang on the error message, we are good to merge on my side. How are we looking on the Italian side? Still reviewing or happy to merge once I am?

[tunetheweb]

@chefleo / @giopunt / @Zizzamia ,

I staged a version of this branch here:

• Home page: https://20210111t180707-dot-webalmanac.uk.r.appspot.com/it/2020/
• Resource Hints chapter: https://20210111t180707-dot-webalmanac.uk.r.appspot.com/it/2020/resource-hints

So you can see what it will look like and see if you can spot any errors.

[Zizzamia]

Sweeet, went over all the open comments left and I think we should be good.
Some translations might need a second PR, but I think we are in a good start. Myself and @giopunt can add more polish in future PRs.
Thank you @bazzadp and @giopunt for helping out @chefleo making this happen, was his first open source contribution just out of university. 👏

[tunetheweb]

Sweeet, went over all the open comments left and I think we should be good.
Some translations might need a second PR, but I think we are in a good start. Myself and @giopunt can add more polish in future PRs.

Thanks @Zizzamia - think we're pretty good now. Will give @giopunt and @chefleo the morning to look over this and merge later today if I hear no reason not to. We can always fix things in subsequent PRs as you say.

Thank you @bazzadp and @giopunt for helping out @chefleo making this happen, was his first open source contribution just out of university. 👏

Well done @chefleo - promise they aren't all this hard! Languages are always harder than code IMHO. And, as the first Italian translation, you also got hit with all the base translations templates in this one. Future Italian translations won't have this and will instead benefit from your hard work here!