feat: Use standard TLS hostname validation for instances with DNS names. #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
approved these changes
Mar 17, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM, as long as we have manually tested on a real instance 👍
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
b2251d2 to
05117dd
Compare
hessjcg
changed the title
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
05117dd to
2b03734
Compare
…er certificate's server name.
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
2b03734 to
0f35e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the connector is configured with a DNS name, or if the Cloud SQL Instance reports that it has a DNS Name,
the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's
TLS certificate must contain a SAN record with the instance's DNS name.
The ConnectSettings API added a field dns_names which contains all of the valid DNS names for
an instance..
See also GoogleCloudPlatform/cloud-sql-go-connector#954