feat: Use standard TLS hostname validation for instances with DNS names #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
2656648 to
23b578d
Compare
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
23b578d to
08c5e88
Compare
This was referenced Mar 12, 2025
jackwotherspoon
requested changes
Mar 12, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
one small suggestion to add a comment, otherwise LGTM
Comment on lines
+107
to
+108
| if dnm.Name != "" && | ||
| dnm.ConnectionType == "PRIVATE_SERVICE_CONNECT" && dnm.DnsScope == "INSTANCE" { |
Collaborator
There was a problem hiding this comment.
let's add a comment here to explain this logic, especially since DnsScope may not be trivial
Collaborator
|
@hessjcg looks like you re-requested a review here but my two nits still have not been addressed... |
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
08c5e88 to
c05654f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hessjcg
force-pushed
the
cas-dns-names-field
branch
2 times, most recently
from
2228dc9 to
94492b7
Compare
hessjcg
force-pushed
the
cas-dns-names-field
branch
3 times, most recently
from
ab9dbd7 to
a97f945
Compare
hessjcg
changed the title
internal/mock/cloudsql.go
Outdated
Comment on lines
54
to
55
| DNSName string | ||
| DNSNames []*sqladmin.DnsNameMapping |
Collaborator
There was a problem hiding this comment.
nit: maybe a comment here explaining the two differences?
Collaborator
There was a problem hiding this comment.
in case an external contributor is trying to update tests
hessjcg
force-pushed
the
cas-dns-names-field
branch
2 times, most recently
from
7c953e0 to
3126f9a
Compare
…er certificate's server name.
hessjcg
force-pushed
the
cas-dns-names-field
branch
from
3126f9a to
c746d06
Compare
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-jdbc-socket-factory
that referenced
this pull request
Mar 19, 2025
…es. (#2125) When the Cloud SQL Instance reports that it has a DNS Name, the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's TLS certificate must contain a SAN record with the instance's DNS name. The ConnectSettings API added a field dns_names which contains all of the valid DNS names for an instance. See also GoogleCloudPlatform/cloud-sql-go-connector#954
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-python-connector
that referenced
this pull request
Mar 20, 2025
…me of the instance. (#1242) The Cloud SQL Instance ConnectSettings added a new field `dns_names` which contains a list of valid DNS names for an instance. The Python Connector will use these DNS names, falling back to the old `dns_name` field if `dns_names` is not populated. Other connectors use this DNS name for hostname validation for the instance's TLS server certificate. However, the python connector does not perform hostname validation due to limitations of python's TLS library. See also: GoogleCloudPlatform/cloud-sql-go-connector#954
hessjcg
added a commit
to GoogleCloudPlatform/cloud-sql-nodejs-connector
that referenced
this pull request
Mar 21, 2025
…es (#428) When the the Cloud SQL Instance reports that it has a DNS Name, the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's TLS certificate must contain a SAN record with the instance's DNS name. The ConnectSettings API added a field dns_names which contains all of the valid DNS names for an instance. See also: GoogleCloudPlatform/cloud-sql-go-connector#954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the the Cloud SQL Instance reports that it has a DNS Name, the connector will use standard TLS hostname validation when checking the server certificate. Now, the server's TLS certificate must contain a SAN record with the instance's DNS name.
The ConnectSettings API added a field
dns_nameswhich contains all of the valid DNS names foran instance.