-
Notifications
You must be signed in to change notification settings - Fork 30
System metrics setup #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/client-side-metrics
Are you sure you want to change the base?
System metrics setup #1041
Conversation
8747506 to
1f835d8
Compare
1f835d8 to
ad4a6e6
Compare
enocom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see the AlloyDB implementation was helpful. Left a couple of comments.
| n := c.openConnsCount.Add(1) | ||
| trace.RecordOpenConnections(ctx, int64(n), d.dialerID, cn.String()) | ||
| trace.RecordDialLatency(ctx, icn, d.dialerID, latency) | ||
| mr.RecordOpenConnection(ctx, attrs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bug in the AlloyDB implementation around open connections, but wow I can't find it yet. Beware!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think I might know what the potential bug -> The GAUGE metric always have more "open" than "close", because we are sending the metric ONLY on every 60s, and when the application shut down, we never record the "-1" of the open_conn GAUGE metric.
Is this the potential bug? (I was testing on how to go around this, but it's gonna be tough to mitigate this one)
Description - This pull request introduces a comprehensive system for collecting and exporting client-side metrics from the Cloud SQL Go Connector, providing valuable insights into the connector's performance and behavior. The key changes include the integration of OpenTelemetry for metrics collection and the introduction of a dedicated telemetry package.
telwith new metrics -