chore: use single monitoring client #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a single metric client for use across multiple metric recorders to avoid wasted resources with multiple clients. Note: the exporter closes the client on shutdown. The dialer already calls shutdown on all exporters. So there is no need to close the client in the dialer. Fixes #674
nancynh
approved these changes
Nov 11, 2025
panavenue
added a commit
to GoogleCloudPlatform/cloud-sql-go-connector
that referenced
this pull request
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a single metric client for use across multiple metric recorders to avoid wasted resources with multiple clients.
Note: the exporter closes the client on shutdown. The dialer already calls shutdown on all exporters. So there is no need to close the client in the dialer.
Fixes #674