Conversation
igor84
left a comment
There was a problem hiding this comment.
Nice work on this big feature. Can't wait to try it out :)
|
@popara96 @igor84 |
|
I never encountered a version like that (that I am aware of) so I don't see any issue with this change. |
| public override INugetPackageSource PackageSource => packageSourceV2; | ||
|
|
||
| /// <inheritdoc /> | ||
| public override List<NugetPackageVersion> Versions => null; |
There was a problem hiding this comment.
I just noticed that this returns null but on line 40 we are passing NugetPackageV2 to FillFromNuspec method that has this line: package.Versions.Add(package.PackageVersion); which will cause NullReferenceException, right? Should we just change that line to package.Versions?.Add(package.PackageVersion);
There was a problem hiding this comment.
you are right. It will be fixed in #568
This PR adds support for NuGet repositories that are using the API version 3. This involves some big changes. e.g.:
INugetPackageinterface with 3 different implementations for v2, v3 or local NuGet package sources.