Skip to content

chore(deps): add IPython dependency and improve import structure in r… #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025
Merged

chore(deps): add IPython dependency and improve import structure in r… #2161

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9b0fcd
chore(deps): add IPython dependency and improve import structure in r…
davidberenstein1957 Apr 25, 2025
92832a0
Regenerating pdm.lock
Apr 25, 2025
7868cad
test: add unit test for report.to_html with embed parameter
davidberenstein1957 Jun 11, 2025
55a857d
test: refactor report.to_html test to use parameterized embed values
davidberenstein1957 Jun 11, 2025
4fad79b
Merge branch 'main' into fix/2156-bug-modulenotfounderror-no-module-n…
henchaves Jun 11, 2025
24d98db
Regenerating pdm.lock
Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion giskard/rag/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import matplotlib
import numpy as np
import pandas as pd
from IPython.core.display import HTML

from ..llm.client.base import LLMClient
from ..llm.embeddings.base import BaseEmbedding
Expand Down Expand Up @@ -135,6 +134,8 @@ def to_html(self, filename=None, embed=False):
return

if embed:
from IPython.core.display import HTML

return HTML(f'<iframe srcdoc="{escape(html)}" width=100% height=800px></iframe>')
return html

Expand Down
Loading
Loading