Skip to content

chore(deps): add IPython dependency and improve import structure in r… #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 11, 2025
Merged

chore(deps): add IPython dependency and improve import structure in r… #2161

merged 6 commits into from
Jun 11, 2025

Conversation

@davidberenstein1957
Copy link
Member

Description

Fixed a small import issue related to iPython

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)

@davidberenstein1957 davidberenstein1957 linked an issue Apr 25, 2025 that may be closed by this pull request
[bug] ModuleNotFoundError: No module named 'IPython' #2156
Closed
@henchaves
Copy link
Member

Hi @davidberenstein1957, could you also add a test for that? To make sure it doesn't fail when calling to_html with embed as True

@henchaves henchaves added the Lockfile Temporary label to update pdm.lock label Apr 25, 2025
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Apr 25, 2025
@davidberenstein1957 davidberenstein1957 requested review from kevinmessiaen and removed request for kevinmessiaen May 26, 2025 07:49
@davidberenstein1957
test: add unit test for report.to_html with embed parameter
7868cad 
- Implemented a new test to verify the functionality of the to_html method in RAGReport when the embed parameter is set to True, ensuring it returns an IPython HTML display object with the expected iframe structure.
@davidberenstein1957
test: refactor report.to_html test to use parameterized embed values
55a857d 
- Updated the test for the RAGReport's to_html method to utilize pytest's parameterization for testing both embed=True and embed=False scenarios, enhancing test coverage and maintainability.
@henchaves henchaves added safe for build Lockfile Temporary label to update pdm.lock labels Jun 11, 2025
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Jun 11, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@henchaves henchaves merged commit 2770824 into main Jun 11, 2025
18 checks passed
@henchaves henchaves deleted the fix/2156-bug-modulenotfounderror-no-module-named-ipython branch June 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henchaves henchaves henchaves approved these changes

@kevinmessiaen kevinmessiaen Awaiting requested review from kevinmessiaen

Assignees

No one assigned

Labels

safe for build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] ModuleNotFoundError: No module named 'IPython'

3 participants

@davidberenstein1957 @henchaves