[GSK-1509][GSK-1990] Add up/download tests for model, dataset and callable

[Inokinoki]

Description

• Separate [GSK-1509] Add tests for ML worker actors behind WebSocket #1504 by websocket actor and model/dataset/callable downloading.
• Improve meta info mock using the DTOs imported in Feature/gsk 1990 add pydantic config ie extra forbid to all dtos #1514
• Fix optional target field in DatasetMetaInfo in GSK-1990

Related Issue

[GSK-1990]
[GSK-1509]

Type of Change

• 📚 Examples / docs / tutorials / dependencies update
• 🔧 Bug fix (non-breaking change which fixes an issue)
• 🥂 Improvement (non-breaking change which improves an existing feature)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 🔐 Security fix

Checklist

• I've read the CODE_OF_CONDUCT.md document.
• I've read the CONTRIBUTING.md guide.
• I've updated the code style using make codestyle.
• I've written tests for all new methods and classes that I created.
• I've written the docstring in Google format for all the methods and classes that I used.

[linear]

GSK-1509 Add integration tests for WebSocket communication

1. Java side integration test

   create a WebSocket endpoint, use a fake WebSocket connection to connect and test

2. Python-Java integration test

   replace callbacks with mock function, use test-container to create a backend. use ~requests~ to call Web interface, then assert the messages received

3. Python integration test

   how to test the implementations in listener.py ? - (testing with tests.utils.MockedClient should work)

[linear]

GSK-1990 Add pydantic config (ie extra = forbid) to all dtos

To avoid any silent typo or error between server and worker, and also client and server, pydantic object should be using some configuration.

[andreybavt]

should it be target: Optional[str] = None ?

[Inokinoki]

Hi Andrey, thanks very much for the review!

The Optional[str] without default value means that we have to provide it in constructor, but it could be None:

>>> from giskard.core.core import DatasetMeta
>>> DatasetMeta()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: DatasetMeta.__init__() missing 6 required positional arguments: 'name', 'column_types', 'column_dtypes', 'number_of_rows', 'category_features', and 'target'

while having the default value means that we do not have to provide it:

>>> from giskard.core.core import DatasetMeta
>>> DatasetMeta()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: DatasetMeta.__init__() missing 5 required positional arguments: 'name', 'column_types', 'column_dtypes', 'number_of_rows', and 'category_features'

In the DatasetMeta case, all of the information should have been provided by the Dataset class, but the target could be None now with LLM model.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[andreybavt]

looks good, I tested on MozartBiographer.ipynb and it worked