Skip to content

Feature/gsk 1990 add pydantic config ie extra forbid to all dtos #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 31, 2023
Merged

Feature/gsk 1990 add pydantic config ie extra forbid to all dtos #1514

merged 8 commits into from
Oct 31, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 27, 2023 •
edited
Loading

Description

To be merged after #1503

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn self-assigned this Oct 27, 2023
@linear
Copy link

linear bot commented Oct 27, 2023

GSK-1990 Add pydantic config (ie extra = forbid) to all dtos

To avoid any silent typo or error between server and worker, and also client and server, pydantic object should be using some configuration.

@Hartorn Hartorn force-pushed the feature/gsk-1990-add-pydantic-config-ie-extra-forbid-to-all-dtos branch 3 times, most recently from b3aa455 to eda4d8f Compare October 27, 2023 14:36
@Hartorn Hartorn marked this pull request as ready for review October 27, 2023 17:09
@Hartorn Hartorn force-pushed the feature/gsk-1990-add-pydantic-config-ie-extra-forbid-to-all-dtos branch from eda4d8f to 7167863 Compare October 30, 2023 09:11
@Hartorn Hartorn force-pushed the feature/gsk-1990-add-pydantic-config-ie-extra-forbid-to-all-dtos branch from 7167863 to 7350dda Compare October 30, 2023 14:43
@Hartorn Hartorn changed the base branch from main to feature/gsk-1888-code-for-callable-functions-becomes-null October 30, 2023 14:43
Base automatically changed from feature/gsk-1888-code-for-callable-functions-becomes-null to main October 31, 2023 04:48
Inokinoki
Inokinoki requested changes Oct 31, 2023
View reviewed changes
giskard/core/suite.py Outdated
@classmethod
def download(cls, client: GiskardClient, project_key: str, suite_id: int) -> "Suite":
suite_json = client.get_suite(client.get_project(project_key).project_id, suite_id)
suite_json: SuiteInfo = client.get_suite(client.get_project(project_key).project_id, suite_id)
Copy link
Member

@Inokinoki Inokinoki Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing suite_json to suite_dto

Copy link
Member Author

@Hartorn Hartorn Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tests/communications/fixtures/with_alias.json
Copy link
Member

@Inokinoki Inokinoki Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need re-generate by ignoring version

Copy link
Member Author

@Hartorn Hartorn Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Hartorn Hartorn force-pushed the feature/gsk-1990-add-pydantic-config-ie-extra-forbid-to-all-dtos branch from f40e124 to c99dc3a Compare October 31, 2023 11:27
Inokinoki
Inokinoki approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.7% 87.7% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit f682ea4 into main Oct 31, 2023
@Hartorn Hartorn deleted the feature/gsk-1990-add-pydantic-config-ie-extra-forbid-to-all-dtos branch October 31, 2023 15:17
@Inokinoki Inokinoki mentioned this pull request Nov 1, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inokinoki Inokinoki Inokinoki approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hartorn @Inokinoki