Skip to content

[GSK-1472] Make company field mandatory on the license request form #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2023
Merged

[GSK-1472] Make company field mandatory on the license request form #1293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e01e4ca
Wrap company name input with a ValidationProvider
henchaves Aug 3, 2023
546a92e
Merge branch 'main' into feature/gsk-1472-make-company-field-mandator…
kevinmessiaen Aug 4, 2023
4c005f3
Merge branch 'main' into feature/gsk-1472-make-company-field-mandator…
henchaves Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions frontend/src/views/setup/Setup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@
<ValidationProvider name="Email" mode="eager" rules="required|email" v-slot="{ errors }">
<v-text-field label="Email*" v-model="email" :error-messages="errors" type="email"></v-text-field>
</ValidationProvider>
<v-text-field label="Company name" v-model="companyName"></v-text-field>
<ValidationProvider name="Company name" mode="eager" rules="required" v-slot="{ errors }">
<v-text-field label="Company name*" v-model="companyName" :error-messages="errors"></v-text-field>
</ValidationProvider>
<ValidationProvider name="Agreement with the privacy policy" mode="eager" :rules="{ required: { allowFalse: false } }" v-slot="{ errors }">

<v-checkbox v-model="termsOfServiceAgree" dense :error-messages="errors">
Expand Down Expand Up @@ -118,13 +120,13 @@

<script setup lang="ts">
import {ref} from "vue";
import axios, {AxiosError} from "axios";
import {useMainStore} from "@/stores/main";
import {api} from "@/api";
import {useRouter} from "vue-router/composables";
import { ref } from "vue";
import axios, { AxiosError } from "axios";
import { useMainStore } from "@/stores/main";
import { api } from "@/api";
import { useRouter } from "vue-router/composables";
import mixpanel from "mixpanel-browser";
import {TYPE} from "vue-toastification";
import { TYPE } from "vue-toastification";
Copy link
Member

@Inokinoki Inokinoki Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a ts/js linter for all these kinds of modifications?

Copy link
Member Author

@henchaves henchaves Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. We plan to do that soon - maybe introduce it together with Vue 3
https://linear.app/giskard/issue/GSK-1282/add-js-linter

const router = useRouter();
Expand Down