[GSK-1472] Make company field mandatory on the license request form #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inokinoki
reviewed
Aug 3, 2023
| import { useRouter } from "vue-router/composables"; | ||
| import mixpanel from "mixpanel-browser"; | ||
| import {TYPE} from "vue-toastification"; | ||
| import { TYPE } from "vue-toastification"; |
There was a problem hiding this comment.
Do we have a ts/js linter for all these kinds of modifications?
There was a problem hiding this comment.
Not yet. We plan to do that soon - maybe introduce it together with Vue 3
https://linear.app/giskard/issue/GSK-1282/add-js-linter
…y-on-the-license-request-form
kevinmessiaen
approved these changes
Aug 4, 2023
…y-on-the-license-request-form
|
Kudos, SonarCloud Quality Gate passed!
|
Hartorn
deleted the
feature/gsk-1472-make-company-field-mandatory-on-the-license-request-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the Company name input in the license request form, making it mandatory.
Related Issue
GSK-1472 (available on Linear)
Type of Change