-
Notifications
You must be signed in to change notification settings - Fork 235
Unpin the Sphinx version #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So sphinx and sphinx_rtd_theme was pinned at #383, and the main change I notice is a condensed API documentation? Old (current):New (This PR):Doesn't look too bad 😄 |
|
Yeah it does. I do like how the vertical whitespace is compressed (for the Aliases especially). Maybe we can configure it somehow (looking at https://sphinx-rtd-theme.readthedocs.io/en/stable/index.html), or pin to a different version? |
|
Note that we also have a custom style.css which may or may not be compatible with new sphinx and sphinx_rtd_theme. |
|
It seems unpinning the sphinx version doesn't change the appearance of the API documentation. Can we merge the PR? |
weiji14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, good to unpin it then!



Description of proposed changes
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.