-
Notifications
You must be signed in to change notification settings - Fork 235
Bump sphinx_rtd_theme from 0.4.3 to 0.5.1 #1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
See #629 for why we pin sphinx_rtd_theme to 0.4.3 |
Yes, there is a lot of whitespace in the parameters section. In my opinion, the search functionality is more important than limiting the whitespace. We can adjust style.css for the latest theme version as necessary. |
|
I think it will be possible to use styles.css to format the parameters section as a block rather than a grid to eliminate the extra whitespace, similar to the older versions of sphinx_rtd_theme. As you mentioned in #629, it will also be necessary to check that the other configurations in style.css are compatible with 0.5.1. Should I do that now in this PR, or better to wait to do it after? |
Better in a separate PR. |
You can also create a new branch from this PR, so you can work on the new style with the latest theme. |
michaelgrund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I think everything needed is done here.
weiji14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One question though, do we need to backport this somehow to the gh-pages branch?
|
Great~ I thought it was a problem with my internet that I cannot use search. |
Yes, it sounds good to me. |
Description of proposed changes
This PR updates sphinx_rtd_theme. Fixes #1149.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version