Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented May 7, 2024

This reverts commit a4d2b8e.

No longer needed after #3182 (comment).

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 7, 2024
@seisman seisman added this to the 0.13.0 milestone May 7, 2024
unaware of periodic or polar boundary conditions.
"""
output_type = validate_output_table_type(output_type, outfile=outfile)
output_type = validate_output_table_type(output_type, outfile)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this change:

Suggested change
output_type = validate_output_table_type(output_type, outfile)
output_type = validate_output_table_type(output_type, outfile=outfile)

@seisman seisman merged commit 127e657 into main May 7, 2024
@seisman seisman deleted the revert-PR-3191 branch May 7, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants