Allow validate_output_table_type to specify the supported output types #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
validator/valid-types
branch
from
ec0f518 to
28eb1df
Compare
seisman
commented
Apr 22, 2024
Comment on lines
+66
to
+67
| + ", ".join(f"'{v}'" for v in valid_types[:-1]) | ||
| + f", or '{valid_types[-1]}'." |
Member
Author
There was a problem hiding this comment.
These two lines convert a list/tuple like ("pandas", "numpy", "file") to a string like 'pandas', 'numpy', or 'file', which is useful for raising a warning or error.
Perhaps we should wrap it as a utility function so that it can be reused.
seisman
changed the title
weiji14
approved these changes
May 6, 2024
Comment on lines
+66
to
+67
| + ", ".join(f"'{v}'" for v in valid_types[:-1]) | ||
| + f", or '{valid_types[-1]}'." |
seisman
added
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some module wrappers,
output_type="numpy"makes no sense (e.g., #3182 (comment)).This PR adds a new parameter
valid_typesto thevalidate_output_table_typefunction. It defaults to('pandas', 'numpy', 'file'). If a module wrapper doesn't supportnumpy, then just setvalid_types=('pandas', 'file').