Skip to content

Conversation

@leouieda
Copy link
Member

Description of proposed changes

Delegate the style checks and Mac builds to Azure instead of Travis (for speed).
Deployment still happens on Travis.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@leouieda
Copy link
Member Author

The library is not being found on Windows because the DLL from conda is gmt.lib and not gmt_w64.lib. We should implement a series of trials for loading the library before giving up. I'll leave that for another PR and merge in with Windows failing now since we don't officially support it yet.

@leouieda leouieda merged commit d84f308 into master Jun 20, 2019
@leouieda leouieda deleted the azure branch June 20, 2019 04:12
weiji14 referenced this pull request in weiji14/pygmt Jun 20, 2019
See if things work on GMT 6.0.0rc1 (#311) and Azure Pipelines (#312).
@weiji14 weiji14 mentioned this pull request Nov 15, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants