Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Aug 9, 2019

No description provided.

@seisman seisman requested a review from leouieda August 9, 2019 14:03
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small cosmetic change to the Shields.io badge, otherwise looks fine.

Co-Authored-By: Wei Ji <[email protected]>
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.rst Outdated
:alt: Travis CI build status
:target: https://travis-ci.org/GenericMappingTools/pygmt
.. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Azure&style=flat-square
.. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, extra space in the front... Maybe don't use the suggested changes.

Suggested change
.. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square
.. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square

@seisman
Copy link
Member Author

seisman commented Aug 22, 2019

All the tests pass now.

@seisman seisman requested review from weiji14 and removed request for leouieda August 22, 2019 05:15
@seisman
Copy link
Member Author

seisman commented Aug 22, 2019

I think this is ready to merge. @weiji14 @leouieda Can any of you approve it? I believe @leouieda is busy with settling in.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, go for it!

@seisman seisman merged commit a184a1b into master Aug 22, 2019
@seisman seisman deleted the disable-windows-ci branch August 22, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants