Skip to content

Conversation

@RyanGlScott
Copy link
Contributor

Now that the mir-json-specific versions of the Rust standard libraries have been moved to the mir-json repo (in GaloisInc/mir-json#85 and GaloisInc/crucible#1319), this patch adjusts the various references to the standard libraries to ensure that SAW's documentation, CI, and test suite remain up to date.

Copy link
Contributor

@sauclovian-g sauclovian-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've forgotten CHANGES.md :-)

@RyanGlScott
Copy link
Contributor Author

What would be an appropriate changelog entry? Nearly all of the changes here are on the mir-json side—aside from some minor differences in error message paths, I don't think anything else has changed that is user-visible.

@sauclovian-g
Copy link
Contributor

sauclovian-g commented Mar 11, 2025

If you've already got an rlibs setup, you'll want/need to migrate it. Pointing this out and referring to the mir-json docs is probably sufficient.

In theory people will see it in the mir-json changelog when they update mir-json, but since it affects the use of saw it's probably best to mention it in saw too.

@RyanGlScott RyanGlScott marked this pull request as ready for review March 26, 2025 16:29
@RyanGlScott RyanGlScott force-pushed the crucible-T1252-remove-crux-mir-std-libs branch from b71f0f1 to e277a24 Compare March 26, 2025 16:37
@RyanGlScott
Copy link
Contributor Author

Note to self: I need to bump the epoch date now that I've made some changes to the Rust tutorial.

@RyanGlScott RyanGlScott marked this pull request as draft March 27, 2025 11:57
This bumps the `crucible` submodule, bringing in the changes from
GaloisInc/crucible#1331 in the process. This requires some minor code changes
to account for `AbortedExit` now having a `GlobalPair`.
Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and
GaloisInc/crucible#1319), this patch adjusts the various references to the
standard libraries to ensure that SAW's documentation, CI, and test suite
remain up to date.
@RyanGlScott RyanGlScott force-pushed the crucible-T1252-remove-crux-mir-std-libs branch from e277a24 to 5401898 Compare March 27, 2025 18:57
@RyanGlScott RyanGlScott marked this pull request as ready for review March 27, 2025 19:03
@RyanGlScott
Copy link
Contributor Author

The crucible-side changes landed after GaloisInc/crucible#1331, so I've pushed a separate commit that does nothing but adapt SAW to the changes from GaloisInc/crucible#1331. (See f261d7d.)

@RyanGlScott RyanGlScott merged commit 3e9b4b6 into master Mar 27, 2025
37 checks passed
@RyanGlScott RyanGlScott deleted the crucible-T1252-remove-crux-mir-std-libs branch March 27, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants