-
Notifications
You must be signed in to change notification settings - Fork 45
crux-mir: Migrate modified Rust standard libraries to mir-json
#1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae7ad66 to
f56210c
Compare
RyanGlScott
commented
Mar 10, 2025
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Mar 10, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and GaloisInc/crucible#1319), this patch adjusts the various references to the standard libraries to ensure that SAW's documentation, CI, and test suite remain up to date.
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Mar 10, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and GaloisInc/crucible#1319), this patch adjusts the various references to the standard libraries to ensure that SAW's documentation, CI, and test suite remain up to date.
f56210c to
eec0224
Compare
eec0224 to
5bdbe07
Compare
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Mar 26, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and GaloisInc/crucible#1319), this patch adjusts the various references to the standard libraries to ensure that SAW's documentation, CI, and test suite remain up to date.
qsctr
reviewed
Mar 26, 2025
Collaborator
qsctr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be updated as well?
Line 70 in 5bdbe07
| $ export CRUX_RUST_LIBRARY_PATH=.../crux-mir/rlibs |
Lines 113 to 116 in 5bdbe07
| Make sure that the `rlibs` symlink exists and points to the right | |
| architecture's libraries. | |
| If not, run the `translate_libs.sh` script as described above under | |
| Installation. |
These have been moved to `mir-json` as part of GaloisInc/mir-json#85. Towards #1252
…rd library migration Now that the `mir-json`-specific versions of the Rust standard libraries have been moved to the `mir-json` repo (in GaloisInc/mir-json#85), this patch adjusts the various references to the standard libraries to ensure that `crux-mir`'s documentation, CI, and test suite remain up to date. Towards #1252
124e97c to
4c83fd4
Compare
RyanGlScott
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Mar 27, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and GaloisInc/crucible#1319), this patch adjusts the various references to the standard libraries to ensure that SAW's documentation, CI, and test suite remain up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
crux-mir/lib, as well as the associatedcrux-mir/translate_libs.shscript. These were migrated to themir-jsonrepo as part of Migrate modified Rust standard libraries fromcrucibletomir-jsonmir-json#85.crux-mir's documentation and CI remain up to date.Fixes #1252.