Skip to content

Conversation

@RyanGlScott
Copy link
Contributor

This patch:

  • Removes the modified versions of the Rust standard libraries that were vendored in to crux-mir/lib, as well as the associated crux-mir/translate_libs.sh script. These were migrated to the mir-json repo as part of Migrate modified Rust standard libraries from crucible to mir-json mir-json#85.
  • Adjusts the various references to the standard libraries to ensure that crux-mir's documentation and CI remain up to date.

Fixes #1252.

@RyanGlScott RyanGlScott force-pushed the T1252-remove-crux-mir-std-libs branch 2 times, most recently from ae7ad66 to f56210c Compare March 10, 2025 20:29
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Mar 10, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and
GaloisInc/crucible#1319), this patch adjusts the various references to the
standard libraries to ensure that SAW's documentation, CI, and test suite
remain up to date.
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Mar 10, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and
GaloisInc/crucible#1319), this patch adjusts the various references to the
standard libraries to ensure that SAW's documentation, CI, and test suite
remain up to date.
@RyanGlScott RyanGlScott force-pushed the T1252-remove-crux-mir-std-libs branch from f56210c to eec0224 Compare March 12, 2025 13:02
@RyanGlScott RyanGlScott marked this pull request as ready for review March 26, 2025 16:29
@RyanGlScott RyanGlScott force-pushed the T1252-remove-crux-mir-std-libs branch from eec0224 to 5bdbe07 Compare March 26, 2025 16:35
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Mar 26, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and
GaloisInc/crucible#1319), this patch adjusts the various references to the
standard libraries to ensure that SAW's documentation, CI, and test suite
remain up to date.
Copy link
Collaborator

@qsctr qsctr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be updated as well?

$ export CRUX_RUST_LIBRARY_PATH=.../crux-mir/rlibs

crucible/crux-mir/README.md

Lines 113 to 116 in 5bdbe07

Make sure that the `rlibs` symlink exists and points to the right
architecture's libraries.
If not, run the `translate_libs.sh` script as described above under
Installation.

These have been moved to `mir-json` as part of
GaloisInc/mir-json#85.

Towards #1252
…rd library migration

Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in
GaloisInc/mir-json#85), this patch adjusts the various
references to the standard libraries to ensure that `crux-mir`'s documentation,
CI, and test suite remain up to date.

Towards #1252
@RyanGlScott RyanGlScott force-pushed the T1252-remove-crux-mir-std-libs branch from 124e97c to 4c83fd4 Compare March 27, 2025 18:05
@RyanGlScott RyanGlScott merged commit 90f602e into master Mar 27, 2025
32 checks passed
@RyanGlScott RyanGlScott deleted the T1252-remove-crux-mir-std-libs branch March 27, 2025 18:45
RyanGlScott added a commit to GaloisInc/saw-script that referenced this pull request Mar 27, 2025
Now that the `mir-json`-specific versions of the Rust standard libraries have
been moved to the `mir-json` repo (in GaloisInc/mir-json#85 and
GaloisInc/crucible#1319), this patch adjusts the various references to the
standard libraries to ensure that SAW's documentation, CI, and test suite
remain up to date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintain modified Rust standard libraries and translate_libs.sh in a separate repo

4 participants