Skip to content

Conversation

@ironcev
Copy link
Member

@ironcev ironcev commented Oct 7, 2025

Description

This PR removes workarounds based on asm blocks used in the std::hash module to obtain an address of a copy-type. Those workarounds are replaced with __addr_of which since #7255 supports taking addresses of copy-types.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev self-assigned this Oct 7, 2025
@ironcev ironcev added the lib: std Standard library label Oct 7, 2025
@ironcev ironcev marked this pull request as ready for review October 7, 2025 08:26
@ironcev ironcev requested review from a team as code owners October 7, 2025 08:26
@ironcev ironcev enabled auto-merge (squash) October 7, 2025 08:26
@ironcev ironcev requested a review from a team October 7, 2025 08:26
@ironcev ironcev merged commit ca96726 into master Oct 7, 2025
45 checks passed
@ironcev ironcev deleted the ironcev/remove-asm-workarounds-from-std-hash branch October 7, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib: std Standard library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants