support __addr_of for all types
#7255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaivaswatha
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #7255 will not alter performanceComparing Summary
|
vaivaswatha
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
vaivaswatha
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
ironcev
requested changes
Jun 25, 2025
Member
ironcev
left a comment
ironcev
left a comment
There was a problem hiding this comment.
This was much simpler then I thought 😄
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Outdated
Show resolved
Hide resolved
test/src/e2e_vm_tests/test_programs/should_pass/language/addrof_intrinsic/src/main.sw
Show resolved
Hide resolved
sway-core/src/semantic_analysis/ast_node/expression/intrinsic_function.rs
Show resolved
Hide resolved
ironcev
added
compiler
vaivaswatha
had a problem deploying
to
fuel-sway-bot
GitHub Actions
Error
Contributor
Author
|
@ironcev . I've done all the changes, except for one which I'm not sure we should do. Once you respond to it, I'll add that (or not). |
vaivaswatha
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
ironcev
approved these changes
Jun 26, 2025
zees-dev
approved these changes
Jun 27, 2025
8 tasks
ironcev
added a commit
that referenced
this pull request
Oct 7, 2025
## Description This PR removes workarounds based on `asm` blocks used in the `std::hash` module to obtain an address of a copy-type. Those workarounds are replaced with `__addr_of` which since #7255 supports taking addresses of copy-types. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
ironcev
pushed a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.