remove trait and replace with concrete impl (#2869)

## Linked Issues/PRs
<!-- List of related issues/PRs -->

## Description
<!-- List of detailed changes -->

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [ ] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [ ] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

Author: MitchTurner

Cargo.lock

@@ -714,6 +714,8 @@ impl Command {
                 max_tx_update_subscriptions: tx_number_active_subscriptions,
                 subscription_ttl,
                 status_cache_ttl: status_cache_ttl.into(),
+                // TODO: Where can I get this value?
+                protocol_public_key: Default::default(),
             },
         };
         Ok(config)

bin/fuel-core/src/cli/run.rs

@@ -3,8 +3,6 @@ use fuel_core_tx_status_manager::ports::P2PPreConfirmationGossipData;
 
 use super::P2PAdapter;
 
-pub mod signature_verification;
-
 #[cfg(feature = "p2p")]
 impl fuel_core_tx_status_manager::ports::P2PSubscriptions for P2PAdapter {
     type GossipedStatuses = P2PPreConfirmationGossipData;

crates/fuel-core/src/service/adapters/tx_status_manager.rs

@@ -67,7 +67,6 @@ use crate::{
             graphql_api::GraphQLBlockImporter,
             import_result_provider::ImportResultProvider,
             ready_signal::ReadySignal,
-            tx_status_manager::signature_verification::PreconfirmationSignatureVerification,
             BlockImporterAdapter,
             BlockProducerAdapter,
             ChainStateInfoProvider,
@@ -257,11 +256,8 @@ pub fn init_sub_services(
         universal_gas_price_provider.clone(),
     );
 
-    let signature_verification = PreconfirmationSignatureVerification;
-
     let tx_status_manager = fuel_core_tx_status_manager::new_service(
         p2p_adapter.clone(),
-        signature_verification,
         config.tx_status_manager.clone(),
     );
     let tx_status_manager_adapter =

crates/fuel-core/src/service/adapters/tx_status_manager/signature_verification.rs

@@ -13,9 +13,10 @@ anyhow = { workspace = true }
 async-trait = { workspace = true }
 derive_more = { workspace = true }
 fuel-core-services = { workspace = true }
-fuel-core-types = { workspace = true, features = ["std"] }
+fuel-core-types = { workspace = true, features = ["std", "serde"] }
 futures = { workspace = true }
 parking_lot = { workspace = true }
+postcard = { workspace = true }
 tokio = { workspace = true }
 tokio-stream = { workspace = true }
 tracing = { workspace = true }

crates/fuel-core/src/service/sub_services.rs

@@ -1,3 +1,4 @@
+use fuel_core_types::fuel_crypto::PublicKey;
 use std::time::Duration;
 
 #[derive(Clone, Debug)]
@@ -8,6 +9,8 @@ pub struct Config {
     pub subscription_ttl: Duration,
     /// Maximum time to keep the status in the cache of the manager.
     pub status_cache_ttl: Duration,
+    /// Protocol Signing Key, i.e. the block signer's public key
+    pub protocol_public_key: PublicKey,
 }
 
 #[cfg(feature = "test-helpers")]
@@ -17,6 +20,7 @@ impl Default for Config {
             max_tx_update_subscriptions: 1000,
             subscription_ttl: Duration::from_secs(60 * 10),
             status_cache_ttl: Duration::from_secs(5),
+            protocol_public_key: PublicKey::default(),
         }
     }
 }