Add V0 algorithm to actual services #2025

MitchTurner · 2024-07-05T23:03:03Z

Part of #1624

The previous PR added all the code for working with the dynamic gas price, but didn't plug it into our services. This PR does the actual dep injection. It also adds gas price estimation to AlgoirthmV0.

This change includes new flags for the CLI:
- "starting-gas-price" - the starting gas price for the gas price algorithm
- "gas-price-change-percent" - the percent change for each gas price update
- "gas-price-threshold-percent" - the threshold percent for determining if the gas price will be increase or decreased
And the following CLI flags are serving a new purpose
- "min-gas-price" - the minimum gas price that the gas price algorithm will return

Checklist

Breaking changes are clearly marked as such in the PR description and changelog
New behavior is reflected in tests
The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

I have reviewed the code myself
I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

Rust SDK
Sway compiler
Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
Someone else?

…ce for previous block

xgreenx · 2024-07-18T10:39:32Z

bin/e2e-test-client/src/tests/script.rs

            .expect("Should be able do decode the Transaction from json representation");

+    let bytes = dry_run_tx_from_json.to_bytes();
+    dbg!(hex::encode(&bytes));


Do we need to keep this dbg?

xgreenx · 2024-07-18T10:43:41Z

bin/fuel-core/src/cli/run.rs

    #[arg(long = "native-executor-version", env)]
    pub native_executor_version: Option<StateTransitionBytecodeVersion>,

+    /// The starting gas price for the network


Taking into account that we also need some configuration for DA as well, maybe it makes sense to move all price-related fields into their config. What do yu think?

Are you thinking that we'd submit all the fields for the config in a single CLI argument? I'm not sure how that affects this specific piece of code.

xgreenx · 2024-07-18T10:45:42Z

bin/fuel-core/src/cli/run.rs

+    #[arg(long = "starting-gas-price", default_value = "1000", env)]
+    pub starting_gas_price: u64,


To be backward compatible the default starting price also should be zero and gas-price-change-percent should be zero as well.

xgreenx · 2024-07-18T10:54:39Z

crates/types/src/blockchain/header.rs


    /// Mutable getter for consensus portion of header
-    fn consensus_mut(&mut self) -> &mut ConsensusHeader<GeneratedConsensusFields> {
+    pub fn consensus_mut(&mut self) -> &mut ConsensusHeader<GeneratedConsensusFields> {


It seems you can move this function just into section below=)

xgreenx · 2024-07-18T10:58:44Z

crates/fuel-gas-price-algorithm/src/v0.rs

+    pub fn worst_case(&self, height: u32) -> u64 {
+        let mut price = self.new_exec_price;
+        for _ in self.for_height..height {
+            let change = price.saturating_mul(self.percentage).saturating_div(100);
+            price = price.saturating_add(change);
+        }
+        price
+    }


It is off-chain logic, so floats are not a problem. The only requirement is that the final gas price should not be less than if we calculated it via iterations. Maybe we could add a test to verify this behavior.

tests/tests/gas_price.rs

xgreenx · 2024-07-19T07:49:35Z

crates/fuel-gas-price-algorithm/src/v0.rs

+        let percentage = self.percentage as f64;
+        let percentage_as_decimal = percentage / 100.0;
+        let multiple = (1.0f64 + percentage_as_decimal).powf(blocks);
+        let mut approx = price * multiple;


Are we sure that this function will not overflow during any of the operations?

The prop test should ensure that it will never happen.

But do we limit the block horizon that comes from the user? What if it is bigger than 10_000?

You're right. We don't check that (because the test iterates over that entire size and I don't want to do u32 max in a test).

I can add another test that makes sure it never overflows :)

@MitchTurner

## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in #1983 * Weekly `cargo update` by @github-actions in #2029 * Add V0 algorithm to actual services by @MitchTurner in #2025 * Weekly `cargo update` by @github-actions in #2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in #2041 * Ignore the message receipt if transaction is reverted by @xgreenx in #2045 * feat: add chain config to Docker images by @mchristopher in #2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in #1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in #2048 ## New Contributors * @mchristopher made their first contribution in #2052 **Full Changelog**: v0.31.0...v0.32.0

@MitchTurner

## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in FuelLabs/fuel-core#1983 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2029 * Add V0 algorithm to actual services by @MitchTurner in FuelLabs/fuel-core#2025 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in FuelLabs/fuel-core#2041 * Ignore the message receipt if transaction is reverted by @xgreenx in FuelLabs/fuel-core#2045 * feat: add chain config to Docker images by @mchristopher in FuelLabs/fuel-core#2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in FuelLabs/fuel-core#1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in FuelLabs/fuel-core#2048 ## New Contributors * @mchristopher made their first contribution in FuelLabs/fuel-core#2052 **Full Changelog**: FuelLabs/fuel-core@v0.31.0...v0.32.0

@MitchTurner

## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in FuelLabs/fuel-core#1983 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2029 * Add V0 algorithm to actual services by @MitchTurner in FuelLabs/fuel-core#2025 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in FuelLabs/fuel-core#2041 * Ignore the message receipt if transaction is reverted by @xgreenx in FuelLabs/fuel-core#2045 * feat: add chain config to Docker images by @mchristopher in FuelLabs/fuel-core#2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in FuelLabs/fuel-core#1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in FuelLabs/fuel-core#2048 ## New Contributors * @mchristopher made their first contribution in FuelLabs/fuel-core#2052 **Full Changelog**: FuelLabs/fuel-core@v0.31.0...v0.32.0

@MitchTurner

## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in FuelLabs/fuel-core#1983 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2029 * Add V0 algorithm to actual services by @MitchTurner in FuelLabs/fuel-core#2025 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in FuelLabs/fuel-core#2041 * Ignore the message receipt if transaction is reverted by @xgreenx in FuelLabs/fuel-core#2045 * feat: add chain config to Docker images by @mchristopher in FuelLabs/fuel-core#2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in FuelLabs/fuel-core#1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in FuelLabs/fuel-core#2048 ## New Contributors * @mchristopher made their first contribution in FuelLabs/fuel-core#2052 **Full Changelog**: FuelLabs/fuel-core@v0.31.0...v0.32.0

@MitchTurner

## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in FuelLabs/fuel-core#1983 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2029 * Add V0 algorithm to actual services by @MitchTurner in FuelLabs/fuel-core#2025 * Weekly `cargo update` by @github-actions in FuelLabs/fuel-core#2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in FuelLabs/fuel-core#2041 * Ignore the message receipt if transaction is reverted by @xgreenx in FuelLabs/fuel-core#2045 * feat: add chain config to Docker images by @mchristopher in FuelLabs/fuel-core#2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in FuelLabs/fuel-core#1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in FuelLabs/fuel-core#2048 ## New Contributors * @mchristopher made their first contribution in FuelLabs/fuel-core#2052 **Full Changelog**: FuelLabs/fuel-core@v0.31.0...v0.32.0

MitchTurner and others added 30 commits June 7, 2024 09:22

Add the algorithm code

ac1aa41

WIP

bc9efa0

Add some tests to define the updater behavior

31ea5c4

Add a couple more tests, WIP getting the second to pass

7e6546a

Fix test, refactor out single update into two

6707c3e

Refactor

09a0c95

WIP rewrite the chart generation stuff

da3c887

Add profit stuff to chart, add rewards

cdfc206

Add some naive profit corrections

15a45ed

Remove the old stuff that is not being used

03c6a4a

Add actual algo that the updater generates, fix tests accordingly

459f8fd

Update gas price with l2 block data

b713739

Use algo generation in simulation

91fe558

Straighten out the profit chart to be aligned after every da_recording

5c3c277

Fix the noise

da7ea98

Refactor to calculate exec gas price eagarly and calculate da gas pri…

f05c594

…ce for previous block

Refactor a bit to allow p and d values, rename some stuff

644c2da

Add d value to tests

9c40f42

WIP

0783439

Use real gas limit values stablize algo a bit.

d7d7d55

Set params to somewhat steady state

106569d

Add average profit values

6db37a6

Cleanup, add naive optimisation

781424f

Refactor

88793e9

Replace d value :), start adding max change

b7c10c6

Add change amount tests, remove unused params

e245f98

Remove avg window

95ed269

Refactor and cleanup

95ab959

Merge remote-tracking branch 'origin' into feature/gas-price-algo

53eebfe

fix fields

5d8d7bb

Merge branch 'master' into feature/add-fuel-algo-updater

f254c91

xgreenx reviewed Jul 18, 2024

View reviewed changes

MitchTurner added 3 commits July 18, 2024 10:49

Remove dbgs, consolodate test methods, change defaults

0c90101

Improve worst_case function performance, add proptest for good coverage

cb4262a

Sort toml

349d283

Voxelot reviewed Jul 18, 2024

View reviewed changes

tests/tests/gas_price.rs Show resolved Hide resolved

MitchTurner added 3 commits July 18, 2024 13:01

Deal with precision errors

1d99650

Fix pub/private func access

d2d0e7a

Fix integ test to allow some over-estimation

0b3cdd0

xgreenx previously approved these changes Jul 19, 2024

View reviewed changes

Add full range of u64 for percentage in prop test

c9e1fcc

MitchTurner dismissed xgreenx’s stale review via c9e1fcc July 19, 2024 18:02

Add comment to explain strange code

627e6cb

MitchTurner requested review from Voxelot and xgreenx July 19, 2024 18:16

xgreenx previously approved these changes Jul 19, 2024

View reviewed changes

Ensure no overflows with new proptest

fa060f8

MitchTurner dismissed xgreenx’s stale review via fa060f8 July 19, 2024 18:26

xgreenx approved these changes Jul 19, 2024

View reviewed changes

MitchTurner enabled auto-merge (squash) July 19, 2024 18:28

MitchTurner merged commit ab5a937 into master Jul 19, 2024

MitchTurner deleted the feature/add-fuel-algo-updater branch July 19, 2024 18:40

MitchTurner mentioned this pull request Aug 2, 2024

Release v0.32.0 #2053

Merged

xgreenx mentioned this pull request Aug 12, 2024

The network doesn't increase the gas price when the demand rises #1966

Closed

MitchTurner mentioned this pull request Sep 19, 2024

Implement worst case scenario for price algorithm v1 #2219

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add V0 algorithm to actual services #2025

Add V0 algorithm to actual services #2025

Uh oh!

MitchTurner commented Jul 5, 2024 •

edited

Loading

Uh oh!

xgreenx Jul 18, 2024

Uh oh!

xgreenx Jul 18, 2024

Uh oh!

MitchTurner Jul 18, 2024

Uh oh!

xgreenx Jul 18, 2024

Uh oh!

xgreenx Jul 18, 2024

Uh oh!

xgreenx Jul 18, 2024

Uh oh!

Uh oh!

xgreenx Jul 19, 2024

Uh oh!

MitchTurner Jul 19, 2024

Uh oh!

xgreenx Jul 19, 2024

Uh oh!

MitchTurner Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		#[arg(long = "starting-gas-price", default_value = "1000", env)]
		pub starting_gas_price: u64,

Add V0 algorithm to actual services #2025

Add V0 algorithm to actual services #2025

Uh oh!

Conversation

MitchTurner commented Jul 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Before requesting review

After merging, notify other teams

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MitchTurner commented Jul 5, 2024 •

edited

Loading