Skip to content

Conversation

@Dentosal
Copy link
Member

@Dentosal Dentosal commented Jun 26, 2024

Work towards FuelLabs/fuel-specs#589. Spec PR FuelLabs/fuel-specs#592.

Adds support for Blob transactions, which are inserted into the onchain database column called Blobs.
Also updates fuel-vm to 0.56.0, which introduces the new tx type.

Work-in-progress, still needs:

  • Regenesis support
  • Tests

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@Dentosal Dentosal self-assigned this Jun 26, 2024
@Dentosal Dentosal changed the title Blob tx support Blob tx support and fuel-vm 0.56.0 Jul 29, 2024
@Dentosal Dentosal requested review from a team, Voxelot and segfault-magnet July 29, 2024 14:52
@Dentosal Dentosal added the breaking A breaking api change label Jul 29, 2024
@Dentosal Dentosal marked this pull request as ready for review July 29, 2024 14:53
assert!(matches!(status, TransactionStatus::Success { .. }));

// When
let script_tx = TransactionBuilder::script(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using new_blob shouldn't the "when" of this test be sending the Blob tx?

The bsiz is just how you chose to verify that the blob is callable, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and yes. Fixed in a0bdfcc.

}
],
"messages": [],
"blobs": [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't break state config. The blobs should be Option

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blobs is #[serde(default)]. Isn't this enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a local node connected to testnet that serde(default) works 👍🏻

StateConfig {
coins: vec![],
messages: vec![],
blobs: vec![],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be None

divi: U64!
ecr1: U64!
eck1: U64!
ed19: U64!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't remove old ed19. Because of backward compatibility we need to add ed19DependentCost. As we did for aloc opcode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in ebe4c21, let me know if that looks correct.

@Dentosal Dentosal requested a review from xgreenx July 30, 2024 21:58
@Voxelot Voxelot enabled auto-merge (squash) August 1, 2024 18:25
@Voxelot Voxelot merged commit c2f5a3a into master Aug 1, 2024
@Voxelot Voxelot deleted the dento/blob-tx branch August 1, 2024 18:44
@danielbate danielbate restored the dento/blob-tx branch August 1, 2024 19:55
@mchristopher mchristopher deleted the dento/blob-tx branch August 1, 2024 20:42
@mchristopher mchristopher restored the dento/blob-tx branch August 1, 2024 20:42
@MitchTurner MitchTurner mentioned this pull request Aug 2, 2024
MitchTurner added a commit that referenced this pull request Aug 6, 2024
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
#1983
* Weekly `cargo update` by @github-actions in
#2029
* Add V0 algorithm to actual services by @MitchTurner in
#2025
* Weekly `cargo update` by @github-actions in
#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
#2045
* feat: add chain config to Docker images by @mchristopher in
#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
#2048

## New Contributors
* @mchristopher made their first contribution in
#2052

**Full Changelog**:
v0.31.0...v0.32.0
kuroki-yosuke added a commit to kuroki-yosuke/core-fuel that referenced this pull request Apr 5, 2025
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
FuelLabs/fuel-core#1983
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2029
* Add V0 algorithm to actual services by @MitchTurner in
FuelLabs/fuel-core#2025
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
FuelLabs/fuel-core#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
FuelLabs/fuel-core#2045
* feat: add chain config to Docker images by @mchristopher in
FuelLabs/fuel-core#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
FuelLabs/fuel-core#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
FuelLabs/fuel-core#2048

## New Contributors
* @mchristopher made their first contribution in
FuelLabs/fuel-core#2052

**Full Changelog**:
FuelLabs/fuel-core@v0.31.0...v0.32.0
@mchristopher mchristopher deleted the dento/blob-tx branch July 15, 2025 16:54
ChapmaBeerbohm added a commit to ChapmaBeerbohm/holo-kit that referenced this pull request Sep 26, 2025
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
FuelLabs/fuel-core#1983
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2029
* Add V0 algorithm to actual services by @MitchTurner in
FuelLabs/fuel-core#2025
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
FuelLabs/fuel-core#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
FuelLabs/fuel-core#2045
* feat: add chain config to Docker images by @mchristopher in
FuelLabs/fuel-core#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
FuelLabs/fuel-core#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
FuelLabs/fuel-core#2048

## New Contributors
* @mchristopher made their first contribution in
FuelLabs/fuel-core#2052

**Full Changelog**:
FuelLabs/fuel-core@v0.31.0...v0.32.0
GeorgeBake added a commit to GeorgeBake/pipeline-cli that referenced this pull request Sep 29, 2025
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
FuelLabs/fuel-core#1983
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2029
* Add V0 algorithm to actual services by @MitchTurner in
FuelLabs/fuel-core#2025
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
FuelLabs/fuel-core#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
FuelLabs/fuel-core#2045
* feat: add chain config to Docker images by @mchristopher in
FuelLabs/fuel-core#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
FuelLabs/fuel-core#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
FuelLabs/fuel-core#2048

## New Contributors
* @mchristopher made their first contribution in
FuelLabs/fuel-core#2052

**Full Changelog**:
FuelLabs/fuel-core@v0.31.0...v0.32.0
BugSeeker84 added a commit to BugSeeker84/fuel-core that referenced this pull request Nov 16, 2025
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
FuelLabs/fuel-core#1983
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2029
* Add V0 algorithm to actual services by @MitchTurner in
FuelLabs/fuel-core#2025
* Weekly `cargo update` by @github-actions in
FuelLabs/fuel-core#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
FuelLabs/fuel-core#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
FuelLabs/fuel-core#2045
* feat: add chain config to Docker images by @mchristopher in
FuelLabs/fuel-core#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
FuelLabs/fuel-core#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
FuelLabs/fuel-core#2048

## New Contributors
* @mchristopher made their first contribution in
FuelLabs/fuel-core#2052

**Full Changelog**:
FuelLabs/fuel-core@v0.31.0...v0.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking api change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants