This repository was archived by the owner on Feb 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Move loaders for css files to devDependencies #101
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ce1b365
Move loaders to devDeps instead
paulathevalley 1a466cd
Update devDeps to match ecology
paulathevalley 83e1802
Show me more errors pls
paulathevalley faf6b86
try npm just for kicks
paulathevalley fd84c44
thats right i deleted it get out of here yarn
paulathevalley cc0975d
upgrade firefox launcher cause it worked for ecology
paulathevalley 46813a0
remove node8 for now and add yarn task just to see what happens
paulathevalley 008436a
go back to yarn taking bets on pass or fail
paulathevalley 23c59fc
try upgrading phantomjs to v2
paulathevalley 5412417
try replacing phantomjs with phantomjs-prebuilt according to yarn issue
paulathevalley 118aabc
add back cache in travis
paulathevalley fca48e2
Add node v8
paulathevalley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,45 +67,46 @@ | |
| "babel-preset-stage-1": "^6.0.0", | ||
| "babel-standalone": "^6.4.4", | ||
| "codemirror": "^5.15.2", | ||
| "css-loader": "~0.9.0", | ||
| "prop-types": "^15.5.10", | ||
| "react": "^15.4.2", | ||
| "react-addons-test-utils": "^15.4.2", | ||
| "react-codemirror": "^1.0.0", | ||
| "react-dom": "^15.4.2", | ||
| "rimraf": "^2.4.0", | ||
| "style-loader": "~0.8.0", | ||
| "url-loader": "~0.5.5", | ||
| "webpack": "^1.10.0" | ||
| "webpack": "^1.12.3" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we ticket out upgrading to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done: #102 |
||
| }, | ||
| "devDependencies": { | ||
| "babel-eslint": "^5.0.0", | ||
| "chai": "^3.2.0", | ||
| "css-loader": "~0.9.0", | ||
| "eslint": "^0.24.1", | ||
| "eslint-config-defaults": "^3.0.3", | ||
| "eslint-plugin-filenames": "^0.1.1", | ||
| "eslint-plugin-react": "^2.6.4", | ||
| "file-loader": "^0.11.2", | ||
| "isparta-loader": "^2.0.0", | ||
| "karma": "^0.12.37", | ||
| "karma": "^0.13.9", | ||
| "karma-chrome-launcher": "^0.2.0", | ||
| "karma-coverage": "^0.4.2", | ||
| "karma-firefox-launcher": "^0.1.6", | ||
| "karma-firefox-launcher": "^1.0.1", | ||
| "karma-ie-launcher": "^0.2.0", | ||
| "karma-mocha": "^0.2.0", | ||
| "karma-phantomjs-launcher": "^0.2.0", | ||
| "karma-phantomjs-shim": "^1.0.0", | ||
| "karma-phantomjs-launcher": "^1.0.4", | ||
| "karma-phantomjs-shim": "^1.1.1", | ||
| "karma-safari-launcher": "^0.1.1", | ||
| "karma-sauce-launcher": "^0.2.14", | ||
| "karma-spec-reporter": "0.0.20", | ||
| "karma-webpack": "^1.6.0", | ||
| "karma-webpack": "^1.7.0", | ||
| "lodash": "^4.13.1", | ||
| "mocha": "^2.2.5", | ||
| "opener": "^1.4.1", | ||
| "phantomjs": "^1.9.17", | ||
| "phantomjs-prebuilt": "^2.1.15", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Evidently
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| "raw-loader": "^0.5.1", | ||
| "react-hot-loader": "^1.2.8", | ||
| "sinon": "^1.15.4", | ||
| "sinon": "^1.16.1", | ||
| "sinon-chai": "^2.8.0", | ||
| "webpack-dev-server": "^1.10.0" | ||
| "style-loader": "~0.8.0", | ||
| "url-loader": "~0.5.5", | ||
| "webpack-dev-server": "^1.14.0" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
- 8please.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ✅