This repository was archived by the owner on Feb 17, 2022. It is now read-only.
Move loaders for css files to devDependencies #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Remember how node v6 was failing (#96)? Now it’s passing, but node v4 is failing! 👉 https://travis-ci.org/FormidableLabs/component-playground/jobs/278014606#L558 Furthermore, if you swap out |
paulathevalley
commented
Sep 21, 2017
| "mocha": "^2.2.5", | ||
| "opener": "^1.4.1", | ||
| "phantomjs": "^1.9.17", | ||
| "phantomjs-prebuilt": "^2.1.15", |
Contributor
Author
There was a problem hiding this comment.
Evidently yarn can build phantomjs-prebuilt but not phantomjs!
Member
There was a problem hiding this comment.
phantomjs is deprecated. phantomjs-prebuilt is the modern version.
Contributor
Author
|
Ready for review! |
kenwheeler
approved these changes
Sep 21, 2017
ryan-roemer
approved these changes
Sep 21, 2017
Member
ryan-roemer
left a comment
ryan-roemer
left a comment
There was a problem hiding this comment.
Just one minor nit for Travis. Rest LGTM without re-review.
| # Disabling tests on node6 until #96 is resolved | ||
| #- "6" | ||
| - 4 | ||
| - 6 |
| "style-loader": "~0.8.0", | ||
| "url-loader": "~0.5.5", | ||
| "webpack": "^1.10.0" | ||
| "webpack": "^1.12.3" |
Member
There was a problem hiding this comment.
Can we ticket out upgrading to webpack@3 later?
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
.cssfiles are only used for the demo, move the loaders todevDependenciesand remove them from the root webpack config.