-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix #4047 #4050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix #4047 #4050
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cd75cce
Add failing test
JooHyukKim 0bfe09b
Refactor existing
JooHyukKim 959744f
revert 2e986dfe5937b28ba39b4d28e0f993802c7c9f68
JooHyukKim f21a06f
Add test
JooHyukKim a88e775
Refactor existing
JooHyukKim 6f6be07
Remove noise in changes
JooHyukKim 1bd0621
Update SerializerProvider.java
JooHyukKim 1d60dca
Update ObjectMapper.java
JooHyukKim 00e0088
Revert everything except valueToTree
JooHyukKim 754bd75
Move test case
JooHyukKim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is slightly misleading: the issue is that it would ignore WRAP_ROOT_VALUE, but after this change it doesn't anymore. the comment makes it sound like now it's ignoring WRAP_ROOT_VALUE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry; I just copied issue description which is misleading. If anyone can do a PR thatd be great (or I'll fix that when I get home).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True