Fix #4047 #4050
Merged
Fix #4047 #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
JooHyukKim
changed the title
|
|
||
| static class TestCommandChild extends TestCommandParent { } | ||
|
|
||
| // [databind#4047] |
Member
There was a problem hiding this comment.
Although this is possible location, maybe rather add under com.fasterxml.jackson.databind.node; maybe in existing TestConversions?
Member
cowtowncoder
left a comment
cowtowncoder
left a comment
There was a problem hiding this comment.
Looks good; I think test should be moved, but otherwise I could merge this.
cowtowncoder
approved these changes
Jul 26, 2023
cowtowncoder
approved these changes
Jul 26, 2023
yawkat
reviewed
Jul 26, 2023
| // inlined 'writeValue' with minor changes: | ||
| // first: disable wrapping when writing | ||
| final SerializationConfig config = getSerializationConfig().without(SerializationFeature.WRAP_ROOT_VALUE); | ||
| // [databind#4047] ObjectMapper.valueToTree will ignore the configuration SerializationFeature.WRAP_ROOT_VALUE |
Member
There was a problem hiding this comment.
comment is slightly misleading: the issue is that it would ignore WRAP_ROOT_VALUE, but after this change it doesn't anymore. the comment makes it sound like now it's ignoring WRAP_ROOT_VALUE
Member
There was a problem hiding this comment.
Yeah sorry; I just copied issue description which is misleading. If anyone can do a PR thatd be great (or I'll fix that when I get home).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4047