Closed
Conversation
polychaeta
reviewed
Jul 25, 2021
polychaeta
left a comment
polychaeta
left a comment
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/9bf55c6b4b4abe461900243eaf754e90/raw/be9999c6fed177687edb3cd0a49d9ade532abffb/cr_9180_1627225533.diff | git apply
diff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c
index 2fde5159b..5fe80bdef 100644
--- a/pimd/pim_cmd.c
+++ b/pimd/pim_cmd.c
@@ -5735,15 +5735,10 @@ DEFUN (show_ip_pim_bsrp,
return CMD_SUCCESS;
}
-DEFUN (show_ip_pim_cand_rp,
- show_ip_pim_cand_rp_cmd,
- "show ip pim candidate-rp [vrf NAME] [json]",
- SHOW_STR
- IP_STR
- PIM_STR
- "PIM Candidate RP state\n"
- VRF_CMD_HELP_STR
- JSON_STR)
+DEFUN(show_ip_pim_cand_rp, show_ip_pim_cand_rp_cmd,
+ "show ip pim candidate-rp [vrf NAME] [json]",
+ SHOW_STR IP_STR PIM_STR
+ "PIM Candidate RP state\n" VRF_CMD_HELP_STR JSON_STR)
{
int idx = 2;
struct vrf *vrf = pim_cmd_lookup_vrf(vty, argv, argc, &idx);
@@ -7597,22 +7592,20 @@ DEFUN (no_ip_pim_rp_prefix_list,
return nb_cli_apply_changes(vty, NULL);
}
-DEFPY (ip_pim_candidate_rp,
- ip_pim_candidate_rp_cmd,
- "[no] ip pim candidate-rp [{priority (0-255)|source <address A.B.C.D|interface IFNAME|loopback$loopback|any$any>}]",
- NO_STR
- IP_STR
- "pim multicast routing\n"
- "Make this router a Candidate RP\n"
- "RP Priority (lower wins)\n"
- "RP Priority (lower wins)\n"
- "Specify IP address for RP operation\n"
- "Local address to use\n"
- "Local address to use\n"
- "Interface to pick address from\n"
- "Interface to pick address from\n"
- "Pick highest loopback address (default)\n"
- "Pick highest address from any interface\n")
+DEFPY(ip_pim_candidate_rp, ip_pim_candidate_rp_cmd,
+ "[no] ip pim candidate-rp [{priority (0-255)|source <address A.B.C.D|interface IFNAME|loopback$loopback|any$any>}]",
+ NO_STR IP_STR
+ "pim multicast routing\n"
+ "Make this router a Candidate RP\n"
+ "RP Priority (lower wins)\n"
+ "RP Priority (lower wins)\n"
+ "Specify IP address for RP operation\n"
+ "Local address to use\n"
+ "Local address to use\n"
+ "Interface to pick address from\n"
+ "Interface to pick address from\n"
+ "Pick highest loopback address (default)\n"
+ "Pick highest address from any interface\n")
{
char cand_rp_xpath[XPATH_MAXLEN];
const struct lyd_node *vrf_dnode;
@@ -7673,15 +7666,13 @@ DEFPY (ip_pim_candidate_rp,
return nb_cli_apply_changes(vty, NULL);
}
-DEFPY (ip_pim_candidate_rp_group,
- ip_pim_candidate_rp_group_cmd,
- "[no] ip pim candidate-rp group A.B.C.D/M",
- NO_STR
- IP_STR
- "pim multicast routing\n"
- "Make this router a Candidate RP\n"
- "Configure groups to become candidate RP for\n"
- "Multicast group prefix\n")
+DEFPY(ip_pim_candidate_rp_group, ip_pim_candidate_rp_group_cmd,
+ "[no] ip pim candidate-rp group A.B.C.D/M",
+ NO_STR IP_STR
+ "pim multicast routing\n"
+ "Make this router a Candidate RP\n"
+ "Configure groups to become candidate RP for\n"
+ "Multicast group prefix\n")
{
char cand_rp_xpath[XPATH_MAXLEN];
const struct lyd_node *vrf_dnode;
diff --git a/pimd/pim_main.c b/pimd/pim_main.c
index 1c24b2d10..aa67b88b6 100644
--- a/pimd/pim_main.c
+++ b/pimd/pim_main.c
@@ -74,15 +74,9 @@ struct zebra_privs_t pimd_privs = {
.cap_num_i = 0};
static const struct frr_yang_module_info *const pimd_yang_modules[] = {
- &frr_filter_info,
- &frr_interface_info,
- &frr_route_map_info,
- &frr_vrf_info,
- &frr_routing_info,
- &frr_pim_info,
- &frr_pim_rp_info,
- &frr_pim_candidate_info,
- &frr_igmp_info,
+ &frr_filter_info, &frr_interface_info, &frr_route_map_info,
+ &frr_vrf_info, &frr_routing_info, &frr_pim_info,
+ &frr_pim_rp_info, &frr_pim_candidate_info, &frr_igmp_info,
};
FRR_DAEMON_INFO(pimd, PIM, .vty_port = PIMD_VTY_PORT,
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedCentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CENTOS8BUILD/config.status/config.statusMake failed for CentOS 8 amd64 build: CentOS 8 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 arm8 build: Failed (click for details)Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18ARM8BUILD/config.log/config.log.gzMake failed for Ubuntu 18.04 arm8 build: Ubuntu 16.04 arm7 build: Failed (click for details)Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI101BUILD/config.log/config.log.gzMake failed for Ubuntu 16.04 arm7 build: FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/FBSD12AMD64/config.status/config.status Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB10BUILD/config.log/config.log.gzMake failed for Debian 10 amd64 build: Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB10BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI012BUILD/config.log/config.log.gzMake failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI014BUILD/config.status/config.status Ubuntu 18.04 amd64 build: Failed (click for details)Make failed for Ubuntu 18.04 amd64 build: Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1804AMD64/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI009BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Failed (click for details)Make failed for Ubuntu 18.04 arm7 build: Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz> Ubuntu 18.04 ppc64le build: Failed (click for details)Make failed for Ubuntu 18.04 ppc64le build: Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1804PPC64LEBUILD/config.status/config.status Debian 9 amd64 build: Failed (click for details)Make failed for Debian 9 amd64 build: Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI021BUILD/config.status/config.status Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 i386 build: Failed (click for details)Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18I386BUILD/config.status/config.statusMake failed for Ubuntu 18.04 i386 build: Ubuntu 16.04 arm8 build: Failed (click for details)Make failed for Ubuntu 16.04 arm8 build: Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> Ubuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1604I386/config.status/config.status Fedora 29 amd64 build: Failed (click for details)Make failed for Fedora 29 amd64 build: Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/F29BUILD/config.status/config.status Debian 11 amd64 build: Failed (click for details)Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB11AMD64/config.status/config.statusMake failed for Debian 11 amd64 build: Debian 11 amd64 build: Unknown Log <config.log.gz> Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsCentOS 8 amd64 build: Failed (click for details)CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CENTOS8BUILD/config.status/config.statusMake failed for CentOS 8 amd64 build: CentOS 8 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 arm8 build: Failed (click for details)Ubuntu 18.04 arm8 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18ARM8BUILD/config.status/config.status Ubuntu 18.04 arm8 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18ARM8BUILD/config.log/config.log.gzMake failed for Ubuntu 18.04 arm8 build: Ubuntu 16.04 arm7 build: Failed (click for details)Ubuntu 16.04 arm7 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI101BUILD/config.status/config.status Ubuntu 16.04 arm7 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI101BUILD/config.log/config.log.gzMake failed for Ubuntu 16.04 arm7 build: FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/FBSD12AMD64/config.status/config.status Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB10BUILD/config.log/config.log.gzMake failed for Debian 10 amd64 build: Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB10BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI012BUILD/config.log/config.log.gzMake failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI014BUILD/config.status/config.status Ubuntu 18.04 amd64 build: Failed (click for details)Make failed for Ubuntu 18.04 amd64 build: Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1804AMD64/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI009BUILD/config.status/config.status Ubuntu 18.04 arm7 build: Failed (click for details)Make failed for Ubuntu 18.04 arm7 build: Ubuntu 18.04 arm7 build: Unknown Log <config.log.gz> Ubuntu 18.04 ppc64le build: Failed (click for details)Make failed for Ubuntu 18.04 ppc64le build: Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1804PPC64LEBUILD/config.status/config.status Debian 9 amd64 build: Failed (click for details)Make failed for Debian 9 amd64 build: Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/CI021BUILD/config.status/config.status Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: Ubuntu 20.04 amd64 build: Unknown Log <config.log.gz> Ubuntu 18.04 i386 build: Failed (click for details)Ubuntu 18.04 i386 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18I386BUILD/config.log/config.log.gz Ubuntu 18.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U18I386BUILD/config.status/config.statusMake failed for Ubuntu 18.04 i386 build: Ubuntu 16.04 arm8 build: Failed (click for details)Make failed for Ubuntu 16.04 arm8 build: Ubuntu 16.04 arm8 build: Unknown Log <config.log.gz> Ubuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/U1604I386/config.status/config.status Fedora 29 amd64 build: Failed (click for details)Make failed for Fedora 29 amd64 build: Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/F29BUILD/config.status/config.status Debian 11 amd64 build: Failed (click for details)Debian 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20511/artifact/DEB11AMD64/config.status/config.statusMake failed for Debian 11 amd64 build: Debian 11 amd64 build: Unknown Log <config.log.gz> |
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8DEB10AMD64-20512/test Topology Tests failed for Topotests debian 10 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-20512/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18I386-20512/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8DEB10AMD64-20512/test Topology Tests failed for Topotests debian 10 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-20512/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18I386-20512/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20512/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log found |
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-20525/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8DEB10AMD64-20525/test Topology Tests failed for Topotests debian 10 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-20525/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18I386-20525/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-20525/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8DEB10AMD64-20525/test Topology Tests failed for Topotests debian 10 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18ARM64-20525/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8U18ARM64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO8U18I386-20525/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20525/artifact/TOPO8U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log found |
donaldsharp
requested changes
Jul 28, 2021
Member
donaldsharp
left a comment
donaldsharp
left a comment
There was a problem hiding this comment.
There is a bunch of code restructuring intermixed with actual code fixes. It would be best if this was broken out.
| struct pim_upstream *up, struct rp_info *rp, | ||
| bool bsr_track_needed, | ||
| struct pim_nexthop_cache *out_pnc) | ||
| static struct pim_nexthop_cache *pim_nht_get(struct pim_instance *pim, |
Member
There was a problem hiding this comment.
This should be broken out into it's own commit. It's a bit of code restructuring that is making it hard to keep track of what is going on.
| upstream); | ||
| } | ||
| listnode_delete(pnc->rp_list, rp); | ||
| if (!pnc) { |
Member
There was a problem hiding this comment.
This code restructuring is fine but it needs to be it's own commit.
Contributor
Author
|
The refactoring/restructuring should all be contained in this commit: I don't think I can split it off further, it doesn't really divide into a cleanup and a changes step, particularly since the previous code was wrong in some corner cases. |
eqvinox
force-pushed
the
pim-cand-rp
branch
from
9c07752 to
f458c00
Compare
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: FailedCheckout code: Failed (click for details)PullReq merge failed. Please rebase your branch: |
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
eqvinox
force-pushed
the
pim-cand-rp
branch
from
f458c00 to
2500f17
Compare
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
eqvinox
force-pushed
the
pim-cand-rp
branch
from
2500f17 to
da1114e
Compare
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log found |
eqvinox
force-pushed
the
pim-cand-rp
branch
from
da1114e to
2ae2d54
Compare
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundTopotests Ubuntu 18.04 i386 part 8: Failed (click for details)Topotests Ubuntu 18.04 i386 part 8: No useful log foundTopotests debian 10 amd64 part 8: Failed (click for details)Topotests debian 10 amd64 part 8: No useful log foundTopotests Ubuntu 18.04 amd64 part 8: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 8: No useful log found |
eqvinox
force-pushed
the
pim-cand-rp
branch
from
2ae2d54 to
b0692eb
Compare
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-318/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
Collaborator
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: FailedCheckout code: Failed (click for details)PullReq merge failed. Please rebase your branch: |
Collaborator
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Collaborator
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-1634/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
The YANG module list is really better as 1-item-per-line. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This proved helpful in debugging the Candidate-RP code. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
The Candidate-RP code is about to use these. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
The upcoming Candidate-RP code needs to send PIM packets that go through normal unicast routing, without forcing a specific output interface. Allow passing in NULL ifp to do that. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
For BSMs, we should track which of the RP candidates in the BSM message are actually available, before trying to use them (which also puts them in NHT for that). This applies for both BSRs as well as BSM receivers. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Should be mostly functional, limited testing at this point. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Should be mostly functional, limited testing at this point. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to pimd for advertising itself as Candidate RP.
Also, bugfixes for the BSM code... hoooo boy what a mess 😭
WORK IN PROGRESS. No tests yet. Those are coming shortly.