Skip to content

Make download links cross-platform #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 15 commits into from
Sep 24, 2020
Merged

Make download links cross-platform #476

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f359b1d
make download links cross-platform
roryabraham Sep 11, 2020
72d65e1
fix js style
roryabraham Sep 11, 2020
bcb5bb7
enable .desktop.js files
roryabraham Sep 23, 2020
1e40b31
move platform-specific links to their own file
roryabraham Sep 23, 2020
a48443c
update README
roryabraham Sep 23, 2020
868317d
fix style and linter
roryabraham Sep 23, 2020
cfe831f
merge master into Rory-FixLinks
roryabraham Sep 23, 2020
ee240ce
remove incorrect comma from README
roryabraham Sep 23, 2020
42937c2
make RegexUtils a commonJS module
roryabraham Sep 23, 2020
d178df1
update README and use index.browser.js instead of index.webify.js
roryabraham Sep 23, 2020
32adfe4
update comment to say default is web
roryabraham Sep 23, 2020
4fc3359
update README again, created separate section for Platform-Specific f…
roryabraham Sep 23, 2020
aace236
nix RegexUtils from webpack file
roryabraham Sep 23, 2020
727506f
use website instead of browser
roryabraham Sep 23, 2020
1089626
delete RegexUtils
roryabraham Sep 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions src/page/home/sidebar/AppLinks.js
View file
Open in desktop

This file was deleted.

41 changes: 41 additions & 0 deletions src/page/home/sidebar/AppLinks/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import React from 'react';
import {Platform} from 'react-native';

import styles from '../../../../style/StyleSheet';
import openURLInNewTab from '../../../../lib/openURLInNewTab';
import Text from '../../../../components/Text';

const AppLinks = () => (
<>
{Platform.OS === 'web' && (
<Text
style={[styles.sidebarFooterLink, styles.mr2]}
onPress={() => openURLInNewTab('https://chat.expensify.com/Chat.dmg')}
>
Desktop
</Text>
)}
{Platform.OS !== 'web' && (
<Text
style={[styles.sidebarFooterLink, styles.mr2]}
onPress={() => openURLInNewTab('https://chat.expensify.com')}
>
Web
</Text>
)}
<Text
style={[styles.sidebarFooterLink, styles.mr2]}
onPress={() => openURLInNewTab('https://testflight.apple.com/join/ucuXr4g5')}
>
iOS
</Text>
<Text
style={[styles.sidebarFooterLink, styles.mr2]}
onPress={() => openURLInNewTab('https://play.google.com/apps/internaltest/4700657970395613233')}
>
Android
</Text>
</>
);

export default AppLinks;
17 changes: 17 additions & 0 deletions src/page/home/sidebar/AppLinks/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from 'react';
import styles from '../../../../style/StyleSheet';
import openURLInNewTab from '../../../../lib/openURLInNewTab';
import Text from '../../../../components/Text';

const AppLinks = () => (
<>
<Text
style={[styles.sidebarFooterLink, styles.mr2]}
onPress={() => openURLInNewTab('https://chat.expensify.com/')}
>
View on web
</Text>
</>
);

export default AppLinks;