-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Make download links cross-platform #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll review once you have created the index.js for the desktop and web 😄 |
|
Okay, I've set this up so that we can use |
|
Had to update the |
.eslintrc.js
Outdated
| node: { | ||
| extensions: [ | ||
| '.js', | ||
| '.webify.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "webify" and could we make that just .web.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, unfortunately we can't just use web.js, because it is already used by a number of files in react-native-web, and the desktop app needs those files. Therefore, we can't exclude .web.js files outright from the webpack build for the desktop app. So we have to just some other extension to denote web-specific implementation, hence: webify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about .browser.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK. Yeah, I think browser or website would work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we like .browser.js or website.js?
I actually think I like website better, because Electron essentially is a sandboxed browser, of sorts.
.eslintrc.js
Outdated
| node: { | ||
| extensions: [ | ||
| '.js', | ||
| '.webify.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Okay, I've updated this PR to:
|
tgolen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes
#287
Tests