-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Added ItemGraph/remap_data guide and advanced ItemGraph sample notebook #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2025-07-08T18:36:50Z I think it might be helpful to be explicit with the out_format argument. |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2025-07-08T18:36:51Z Line #2. result_form = graph.get_item("41dd3cca32914cc7ae8fd3a727f44e17")
Might be helpful to call this variable result_flyr since that's what it is...rather than form? |
|
View / edit / reply to this conversation on ReviewNB jyaistMap commented on 2025-07-08T18:36:52Z
nparavicini7 commented on 2025-07-09T22:16:03Z Addressed 2 and 3. For 1, no, should we provide a list of the items compatible with remap_data()? There's only a subset currently. We could do an asterisk and list at the bottom or something |
|
View / edit / reply to this conversation on ReviewNB ManushiM commented on 2025-07-09T02:56:17Z do we want to specify version numbers for when a feature was added? |
|
View / edit / reply to this conversation on ReviewNB ManushiM commented on 2025-07-09T02:56:17Z maybe replace tedious with time-consuming, to avoid the negative connotation? |
suggestions for updates to itemgraph guide
|
Addressed 2 and 3. For 1, no, should we provide a list of the items compatible with remap_data()? There's only a subset currently. We could do an asterisk and list at the bottom or something View entire conversation on ReviewNB |
|
Addressed all of your comments @jyaistMap @ManushiM. The one thing I didn't add was a list of the compatible JSON-based items for remap_data()- I think that would be more appropriate for the docstring of the function |
Good idea. Sounds appropriate. |
jyaistMap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- submitted #2319 for formatting and spelling - after that lgtm
Update hyperlink formats and misspellings
Added a beginner/intermediate guide on the ItemGraph, remap_data(), and how to use them together, and then added a sample notebook that users can download to maintain their own organization-wide dependency graph and use it for analysis/admin workflows. Thank you @ManushiM for the section on automating it