Skip to content

Conversation

@jyaistMap
Copy link
Collaborator

@nparavicini7

  • some suggested edits, like adding an Introduction, small grammatical stuff, bullet points in one place, and hyperlinks

@jyaistMap jyaistMap requested a review from nparavicini7 July 8, 2025 18:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jyaistMap jyaistMap changed the title Jy rvw graph guides suggestions for updates to itemgraph guide Jul 8, 2025
Copy link
Collaborator

@nparavicini7 nparavicini7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On board with all of the wording changes, but clicking all of those hyperlinks you added lead me to 404 github pages- I'm a bit confused by that, especially the ones that just go github.com/python. Is that intentional? Will that be smoothed over during the build later?

@jyaistMap
Copy link
Collaborator Author

hey @nparavicini7 - The best format for hyperlinks according to the Dev Website team is to use relative paths as I did with those. They don't properly work in a local environment, but through the Gatsby application they do. Going from guide to guide is one format; going from guide to sample is another. It is a bit confusing - but those formats work.

@jyaistMap jyaistMap requested a review from nparavicini7 July 9, 2025 15:42
@nparavicini7 nparavicini7 merged commit 49fa14e into graph_guides Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants