Skip to content

Conversation

@SchroederSteffen
Copy link
Contributor

@SchroederSteffen SchroederSteffen commented Oct 30, 2025

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Fix #71874.
Fix #73231.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 30, 2025

@SchroederSteffen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

2 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73989,
  "author": "SchroederSteffen",
  "headCommitOid": "5d82ed1a4103709cf8dc524448510cc68ec0e280",
  "mergeBaseOid": "fbdfddb1b3fda0edc438f3c39d23d1680e8ac023",
  "lastPushDate": "2025-10-30T12:01:13.000Z",
  "lastActivityDate": "2025-11-12T07:04:20.000Z",
  "mergeOfferDate": "2025-11-11T20:46:50.000Z",
  "mergeRequestDate": "2025-11-12T07:04:20.000Z",
  "mergeRequestUser": "SchroederSteffen",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "sinon-test",
      "kind": "edit",
      "files": [
        {
          "path": "types/sinon-test/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/sinon-test/sinon-test-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mummybot"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "sinon",
      "kind": "edit",
      "files": [
        {
          "path": "types/sinon/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/sinon/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/sinon/sinon-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mrbigdog2u",
        "nicojs",
        "43081j",
        "gjednaszewski",
        "johnjesse",
        "alecf",
        "SimonSchick",
        "lo1tuma"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2025-11-11T20:45:46.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "43081j",
      "date": "2025-10-31T09:43:49.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3467662788,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @mummybot @MrBigDog2U @nicojs @43081j @gjednaszewski @johnjesse @alecf @SimonSchick @lo1tuma — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Oct 30, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 30, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Oct 30, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Oct 30, 2025
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 31, 2025
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 10, 2025
@typescript-bot
Copy link
Contributor

Re-ping @mummybot, @MrBigDog2U, @nicojs, @gjednaszewski, @johnjesse, @alecf, @SimonSchick, @lo1tuma:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 11, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Nov 11, 2025
@SchroederSteffen
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Nov 12, 2025
@typescript-bot typescript-bot merged commit 3a98501 into DefinitelyTyped:master Nov 12, 2025
4 checks passed
@SchroederSteffen SchroederSteffen deleted the sinon-v20 branch November 12, 2025 07:05
@SchroederSteffen
Copy link
Contributor Author

Published successfully as https://www.npmjs.com/package/@types/sinon/v/20.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Edits multiple packages Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants