Skip to content

Conversation

@mroderick
Copy link
Member

Everyone should be using native promises by now, or should know how to stub natives

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mroderick mroderick added the semver:major changes will cause a new major version label Mar 17, 2025
@mroderick mroderick requested a review from fatso83 March 17, 2025 18:27
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (95d4b8f) to head (d4e77e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   96.05%   95.82%   -0.24%     
==========================================
  Files          40       39       -1     
  Lines        1926     1891      -35     
==========================================
- Hits         1850     1812      -38     
- Misses         76       79       +3     
Flag Coverage Δ
unit 95.82% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit.

All cases I could find just used the default Promise implementation anyway, when using this function.

https://github.com/search?q=.usingPromise+%28language%3AJavaScript+OR+language%3ATypeScript+%29+-path%3Alib%2Fsinon%2F*.js&type=code

Everyone should be using native promises by now, or should know how to stub natives
@mroderick mroderick force-pushed the remove-using-promise branch from c9d66cd to d4e77e0 Compare March 24, 2025 18:15
@mroderick mroderick merged commit b6daed2 into main Mar 24, 2025
13 of 14 checks passed
@mroderick mroderick deleted the remove-using-promise branch March 24, 2025 18:18
@mroderick
Copy link
Member Author

This has been published to the npm registry as part of [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:major changes will cause a new major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants