-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Bump pygithub from 1.58.2 to 2.3.0 #9948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Powered by DryRun Security |
28ffa9b to
d88099b
Compare
d88099b to
b8e1e60
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
e9c18c3 to
36f524f
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cneill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this one is passing tests... PyGithub deprecated the positional argument we use to instantiate the Github class back in 1.59.0 (you can see it marked deprecated in their docs for the class here)
Here are examples of us using that positional argument:
- https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/github.py#L35
- https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/github_issue_link/views.py#L35
- https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/product/views.py#L769
Dependabot couldn't find the original pull request head commit, d88099b.
36f524f to
78d29bb
Compare
|
May I ask what is status of this PR? It is one of the blockers for #10473. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@kiblik See cneill's comments at #9948 (review) The short answer is that changes are needed to update this Python module and there's not a PR for that or tests for Github integration. Since this GHA were green and this definitely had breaking changes, we obviously don't have good test coverage for the Github integration as well. |
|
Superseded by #10808. |
Bumps pygithub from 1.58.2 to 2.3.0.
Release notes
Sourced from pygithub's releases.
... (truncated)
Changelog
Sourced from pygithub's changelog.
... (truncated)
Commits
7266e81Release v2.3.0 (#2926)e4106e0Support oauth for enterprise (#2780)d65fc30Create release with optional name and message when generate_release_notes is ...0784f83Support creation of Dependabot Organization and Repository Secrets (#2874)9e09245Add missing attributes to WorkflowJob (#2921)e3d3653Fix imports in authentication docs (#2923)c788985Addcreatedandcheck_suite_idfilter for Repository WorkflowRuns (#2891)0b8435fAssert requester argument type in Auth (#2912)96ad19aCI: add docformatter to precommit (#2614)b542438Revert having allowed values for add_to_collaborators (#2905)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)