-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Bump pygithub from 1.58.2 to 2.6.1 #11886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DryRun Security SummaryPyGithub library was upgraded from version 1.58.2 to 2.6.1 in requirements.txt, with potential security improvements and a recommendation for thorough testing and compatibility review. Expand for full summary
Security Findings:
|
mtesauro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes in this one - see #9948 (review)
4420229 to
cab7e96
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@dependabot rebase |
cab7e96 to
46625ce
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
|
JFYI: I requested rebase because:
|
|
@dependabot rebase |
46625ce to
0919efd
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@dependabot rebase |
Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.58.2 to 2.6.1. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/v2.6.1/doc/changes.rst) - [Commits](PyGithub/PyGithub@v1.58.2...v2.6.1) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
0919efd to
98241e5
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
|
Ideally we don't leave this open for too long as it blocks python upgrades (and maybe in the future other upgrades such as Django which will be EOL at some point). The fix is almost trivial so I quickly added it. |
@valentijnscholten It would appear that we've moved past the blockers in #9948 in this PR, correct? I'm not sure what kind of test coverage we have for pygithub so wanted to double-check before I re-review this one. |
|
Yeah this PR solves the last "blocker". IIRC @Maffooch had an instance he could do a quick test with to see if the GitHub auth is still working. |
|
@valentijnscholten Cool. I'll wait till I hear from him or he approves this meaning his test worked as expected. 👍 |
Maffooch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Bumps pygithub from 1.58.2 to 2.6.1.
Release notes
Sourced from pygithub's releases.
... (truncated)
Changelog
Sourced from pygithub's changelog.
... (truncated)
Commits
da30d6eReleasing v2.6.1 (#3230)f997a2fAddCodeSecurityConfigRepositoryreturned by `get_repos_for_code_security_c...048a1a3MakeGitTag.verificationreturnGitCommitVerification(#3226)9329744Fix incorrect deprecated import (#3225)d12e7d4Remove schema fromDeployment, removemessageattribute (#3223)f975552Fix broken pickle support forAuthclasses (#3211)f5dc1c7Mention removal ofAppAuth.private_keyin changelog (#3212)e3e07d7Fix PyPi upload (#3200)620c839Fix PyPi upload (#3199)bf98e17Release 2.6.0 (#3198)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)