[system-health] When disabling a feature the SYSTEM_READY|SYSTEM_STAT…#33
Closed
DavidZagury wants to merge 3 commits intomasterfrom
Closed
[system-health] When disabling a feature the SYSTEM_READY|SYSTEM_STAT…#33DavidZagury wants to merge 3 commits intomasterfrom
DavidZagury wants to merge 3 commits intomasterfrom
Conversation
…E was not updated
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
from
ef9563b to
f3a5ee0
Compare
DavidZagury
force-pushed
the
fix_feature_disable_issue
branch
from
f3a5ee0 to
aea4d55
Compare
Junchao-Mellanox
approved these changes
Apr 24, 2023
DavidZagury
pushed a commit
that referenced
this pull request
Apr 27, 2025
…tically (sonic-net#22363) #### Why I did it src/sonic-dash-api ``` * 874b5c5 - (HEAD -> master, origin/master, origin/HEAD) Add dash HA tables (#33) (24 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tically (sonic-net#753) #### Why I did it src/sonic-sairedis ``` * 0c1750e - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #32 from r12f/cherry-pick-1509 (9 hours ago) [Riff] |\ | failure_prs.log skip_prs.log 995e71f - [sairedis/syncd] Implement bulk get support (sonic-net#1509) (19 hours ago) [Stepan Blyshchak] * | 2f4d39d - Fixing the sairedis build issue caused at https://github.com/sonic-ne… (#33) (18 hours ago) [mssonicbld] * | 1da1f58 - Fix counter issues on VS platform (#35) (18 hours ago) [mssonicbld] |/ * 4d1b885 - Merge pull request #28 from r12f/cherry-pick-1234 (20 hours ago) [Riff] * 3c5f3e1 - sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd (sonic-net#1234) (30 hours ago) [r12f] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tomatically (sonic-net#843) #### Why I did it src/sonic-linux-kernel ``` * c4c81ba - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#33) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…omatically (sonic-net#864) #### Why I did it src/sonic-swss-common ``` * a50e196 - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#33) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…E was not updated
Why I did it
If you enable feature and then disable it, System Ready status change to Not Ready
A disabled feature should no affect the system ready status.
Work item tracking
How I did it
During the disable flow of dhcp_relay, it entered the dnsrvs_name list, which caused the SYSTEM_STATE key to be set to DOWN. Right after that, the dhcp_relay service was removed from the full service list, however, but, when it was removed from the dnsrvs_name, there was no flow to reset the system state back to UP even though there was no more services in down state.
How to verify it
Should see
System is readyWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)