Improve and fix issues with PROD signing#28
Closed
DavidZagury wants to merge 4 commits intomasterfrom
Closed
Conversation
DavidZagury
commented
Apr 2, 2023
DavidZagury
commented
Apr 2, 2023
rules/config
Outdated
Owner
Author
There was a problem hiding this comment.
Extra arguments options for vendor to use in order to run his specific prod signing script
DavidZagury
commented
Apr 2, 2023
… with flags to align to the dev script
…s to pass their own arguments on the prod signing script
This is done because when there is a default value, we mount to this path, and this creates this folder on the host.
DavidZagury
force-pushed
the
master_prod_signing
branch
from
a14dd2c to
8677eb7
Compare
davidpil2002
reviewed
Apr 3, 2023
| # Mount the Signing prod tool in the slave container | ||
| $(info "SECURE_UPGRADE_PROD_SIGNING_TOOL": "$(SECURE_UPGRADE_PROD_SIGNING_TOOL)") | ||
| ifneq ($(SECURE_UPGRADE_PROD_SIGNING_TOOL),) | ||
| SECURE_UPGRADE_PROD_SIGNING_TOOL_DST = /sonic/scripts/$(shell basename -- $(SECURE_UPGRADE_PROD_SIGNING_TOOL)) |
There was a problem hiding this comment.
you did this logic in slave.mk, pls remove it from here
Owner
Author
There was a problem hiding this comment.
We need it here for the DOCKER_RUN flag that mount the tool on the next line
There was a problem hiding this comment.
We need it here for the DOCKER_RUN flag that mount the tool on the next line
so removed just 323 and save the line that you need that mounting the tool without the _DST suffix.
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
… automatically (sonic-net#635) #### Why I did it src/sonic-platform-common ``` * d9de488 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#28) (7 hours ago) [mssonicbld] * 30112ca - [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#26) (31 hours ago) [mssonicbld] * a36263b - [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#24) (2 days ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tically (sonic-net#753) #### Why I did it src/sonic-sairedis ``` * 0c1750e - (HEAD -> 202412, origin/HEAD, origin/202412) Merge pull request #32 from r12f/cherry-pick-1509 (9 hours ago) [Riff] |\ | failure_prs.log skip_prs.log 995e71f - [sairedis/syncd] Implement bulk get support (sonic-net#1509) (19 hours ago) [Stepan Blyshchak] * | 2f4d39d - Fixing the sairedis build issue caused at https://github.com/sonic-ne… (#33) (18 hours ago) [mssonicbld] * | 1da1f58 - Fix counter issues on VS platform (#35) (18 hours ago) [mssonicbld] |/ * 4d1b885 - Merge pull request #28 from r12f/cherry-pick-1234 (20 hours ago) [Riff] * 3c5f3e1 - sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd (sonic-net#1234) (30 hours ago) [r12f] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tomatically (sonic-net#789) #### Why I did it src/sonic-linux-kernel ``` * 971a5d3 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (#28) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Apr 28, 2025
…omatically (sonic-net#811) #### Why I did it src/sonic-swss-common ``` * fc3fba2 - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (#28) (16 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Build SONiC using your own prod script
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)