chore(llmobs): add classes to fix type checks for canonical IDs and tags#16673
Conversation
Codeowners resolved as |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate gary/fix-typing-tags-canonid (3090ace) with baseline main (42c4bf7) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 102.900µs (SLO: <130.000µs 📉 -20.8%) vs baseline: +1.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 101.327µs (SLO: <130.000µs 📉 -22.1%) vs baseline: -2.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ add_inplace_noaspectTime: ✅ 28.286µs (SLO: <40.000µs 📉 -29.3%) vs baseline: +0.5% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ add_noaspectTime: ✅ 48.950µs (SLO: <70.000µs 📉 -30.1%) vs baseline: -0.7% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 252.789µs (SLO: <400.000µs 📉 -36.8%) vs baseline: +1.7% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 634.146µs (SLO: <800.000µs 📉 -20.7%) vs baseline: -3.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ bytearray_extend_noaspectTime: ✅ 264.860µs (SLO: <400.000µs 📉 -33.8%) vs baseline: -2.8% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytearray_noaspectTime: ✅ 135.825µs (SLO: <300.000µs 📉 -54.7%) vs baseline: -3.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ bytes_aspectTime: ✅ 220.701µs (SLO: <300.000µs 📉 -26.4%) vs baseline: +1.5% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.4% ✅ bytes_noaspectTime: ✅ 132.390µs (SLO: <200.000µs 📉 -33.8%) vs baseline: -1.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytesio_aspectTime: ✅ 3.772ms (SLO: <5.000ms 📉 -24.6%) vs baseline: -0.5% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ bytesio_noaspectTime: ✅ 318.549µs (SLO: <420.000µs 📉 -24.2%) vs baseline: +0.9% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.2% ✅ capitalize_aspectTime: ✅ 89.302µs (SLO: <300.000µs 📉 -70.2%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ capitalize_noaspectTime: ✅ 253.200µs (SLO: <300.000µs 📉 -15.6%) vs baseline: -0.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.1% ✅ casefold_aspectTime: ✅ 89.133µs (SLO: <500.000µs 📉 -82.2%) vs baseline: +0.5% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ casefold_noaspectTime: ✅ 305.239µs (SLO: <500.000µs 📉 -39.0%) vs baseline: -0.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ decode_aspectTime: ✅ 86.428µs (SLO: <100.000µs 📉 -13.6%) vs baseline: -0.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 152.317µs (SLO: <210.000µs 📉 -27.5%) vs baseline: -0.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ encode_aspectTime: ✅ 84.432µs (SLO: <200.000µs 📉 -57.8%) vs baseline: ~same Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ encode_noaspectTime: ✅ 140.213µs (SLO: <200.000µs 📉 -29.9%) vs baseline: -0.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.1% ✅ format_aspectTime: ✅ 14.579ms (SLO: <19.200ms 📉 -24.1%) vs baseline: -0.5% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.3% ✅ format_map_aspectTime: ✅ 16.369ms (SLO: <21.500ms 📉 -23.9%) vs baseline: -0.1% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +4.4% ✅ format_map_noaspectTime: ✅ 369.177µs (SLO: <500.000µs 📉 -26.2%) vs baseline: -1.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ format_noaspectTime: ✅ 302.461µs (SLO: <500.000µs 📉 -39.5%) vs baseline: -1.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.5% ✅ index_aspectTime: ✅ 126.788µs (SLO: <300.000µs 📉 -57.7%) vs baseline: +6.7% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ index_noaspectTime: ✅ 40.099µs (SLO: <300.000µs 📉 -86.6%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ join_aspectTime: ✅ 212.164µs (SLO: <300.000µs 📉 -29.3%) vs baseline: -1.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 142.821µs (SLO: <300.000µs 📉 -52.4%) vs baseline: +1.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ ljust_aspectTime: ✅ 582.737µs (SLO: <700.000µs 📉 -16.8%) vs baseline: 📈 +14.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ ljust_noaspectTime: ✅ 260.155µs (SLO: <300.000µs 📉 -13.3%) vs baseline: -1.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 298.748µs (SLO: <500.000µs 📉 -40.3%) vs baseline: -1.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.2% ✅ lower_noaspectTime: ✅ 233.814µs (SLO: <300.000µs 📉 -22.1%) vs baseline: -0.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ lstrip_aspectTime: ✅ 0.271ms (SLO: <3.000ms 📉 -91.0%) vs baseline: -2.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: +0.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ modulo_aspectTime: ✅ 14.348ms (SLO: <18.750ms 📉 -23.5%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.759ms (SLO: <19.350ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 14.390ms (SLO: <18.900ms 📉 -23.9%) vs baseline: -0.9% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.600ms (SLO: <19.150ms 📉 -23.8%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.2% ✅ modulo_noaspectTime: ✅ 0.361ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 18.441ms (SLO: <24.000ms 📉 -23.2%) vs baseline: +0.4% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ replace_noaspectTime: ✅ 279.468µs (SLO: <300.000µs -6.8%) vs baseline: -1.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ repr_aspectTime: ✅ 314.041µs (SLO: <420.000µs 📉 -25.2%) vs baseline: -2.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.1% ✅ repr_noaspectTime: ✅ 46.575µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 381.352µs (SLO: <500.000µs 📉 -23.7%) vs baseline: -1.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ rstrip_noaspectTime: ✅ 185.286µs (SLO: <300.000µs 📉 -38.2%) vs baseline: +1.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ slice_aspectTime: ✅ 183.207µs (SLO: <300.000µs 📉 -38.9%) vs baseline: +0.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ slice_noaspectTime: ✅ 53.780µs (SLO: <90.000µs 📉 -40.2%) vs baseline: -0.8% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.1% ✅ stringio_aspectTime: ✅ 4.418ms (SLO: <5.000ms 📉 -11.6%) vs baseline: 📈 +14.9% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ stringio_noaspectTime: ✅ 346.271µs (SLO: <500.000µs 📉 -30.7%) vs baseline: -2.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 268.804µs (SLO: <350.000µs 📉 -23.2%) vs baseline: -2.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 175.122µs (SLO: <240.000µs 📉 -27.0%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ swapcase_aspectTime: ✅ 332.564µs (SLO: <500.000µs 📉 -33.5%) vs baseline: -1.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.2% ✅ swapcase_noaspectTime: ✅ 269.539µs (SLO: <400.000µs 📉 -32.6%) vs baseline: -0.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 323.392µs (SLO: <500.000µs 📉 -35.3%) vs baseline: -1.7% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.4% ✅ title_noaspectTime: ✅ 258.716µs (SLO: <400.000µs 📉 -35.3%) vs baseline: -2.0% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 491.590µs (SLO: <700.000µs 📉 -29.8%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 424.427µs (SLO: <500.000µs 📉 -15.1%) vs baseline: -1.7% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.0% ✅ upper_aspectTime: ✅ 295.731µs (SLO: <500.000µs 📉 -40.9%) vs baseline: -1.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 235.822µs (SLO: <400.000µs 📉 -41.0%) vs baseline: +0.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 512.511µs (SLO: <700.000µs 📉 -26.8%) vs baseline: 📈 +19.3% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +5.4% ✅ ospathbasename_noaspectTime: ✅ 430.513µs (SLO: <700.000µs 📉 -38.5%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <46.000MB -7.2%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 622.415µs (SLO: <700.000µs 📉 -11.1%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <46.000MB -7.4%) vs baseline: +4.5% ✅ ospathjoin_noaspectTime: ✅ 635.716µs (SLO: <700.000µs -9.2%) vs baseline: +0.6% Memory: ✅ 42.684MB (SLO: <46.000MB -7.2%) vs baseline: +4.6% ✅ ospathnormcase_aspectTime: ✅ 347.421µs (SLO: <700.000µs 📉 -50.4%) vs baseline: -1.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 359.804µs (SLO: <700.000µs 📉 -48.6%) vs baseline: +0.5% Memory: ✅ 42.723MB (SLO: <46.000MB -7.1%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 488.996µs (SLO: <700.000µs 📉 -30.1%) vs baseline: +0.4% Memory: ✅ 42.743MB (SLO: <46.000MB -7.1%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 500.382µs (SLO: <700.000µs 📉 -28.5%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <46.000MB -7.4%) vs baseline: +4.2% ✅ ospathsplitdrive_aspectTime: ✅ 373.387µs (SLO: <700.000µs 📉 -46.7%) vs baseline: ~same Memory: ✅ 42.723MB (SLO: <46.000MB -7.1%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 72.566µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 42.625MB (SLO: <46.000MB -7.3%) vs baseline: +4.5% ✅ ospathsplitext_aspectTime: ✅ 458.142µs (SLO: <700.000µs 📉 -34.6%) vs baseline: -1.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 463.638µs (SLO: <700.000µs 📉 -33.8%) vs baseline: +0.1% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +4.6% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.497ms (SLO: <32.950ms -4.4%) vs baseline: +0.8% Memory: ✅ 36.687MB (SLO: <39.250MB -6.5%) vs baseline: +4.3% ✅ mediumTime: ✅ 3.111ms (SLO: <3.200ms -2.8%) vs baseline: +0.5% Memory: ✅ 35.507MB (SLO: <38.750MB -8.4%) vs baseline: +4.2% ✅ smallTime: ✅ 363.603µs (SLO: <370.000µs 🟡 -1.7%) vs baseline: +3.9% Memory: ✅ 35.665MB (SLO: <38.750MB -8.0%) vs baseline: +4.6%
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This PR is rejected because it was updated |
Description
tags and canonical IDs should not be required when creating a dataset record, so add optional classes to allow them to be not required
Testing
ran
MYPYPATH=. mypy --ignore-missing-imports test-dataset-record-create.pyin dd-sourcewhere the file is
Risks
Additional Notes