Skip to content

Commit 3090ace

Browse files
committed
add classes to fix type checks for canonical IDs and tags
1 parent 42c4bf7 commit 3090ace

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

ddtrace/llmobs/_experiment.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,14 @@ class Project(TypedDict):
392392
_id: str
393393

394394

395-
class DatasetRecordRaw(TypedDict):
395+
class _DatasetRecordRawOptional(TypedDict, total=False):
396+
tags: list[str]
397+
398+
399+
class DatasetRecordRaw(_DatasetRecordRawOptional):
396400
input_data: DatasetRecordInputType
397401
expected_output: JSONType
398402
metadata: dict[str, Any]
399-
tags: list[str]
400403

401404

402405
class _UpdatableDatasetRecordOptional(TypedDict, total=False):
@@ -410,11 +413,14 @@ class UpdatableDatasetRecord(_UpdatableDatasetRecordOptional):
410413
record_id: str
411414

412415

413-
class DatasetRecord(DatasetRecordRaw):
414-
record_id: str
416+
class _DatasetRecordOptional(TypedDict, total=False):
415417
canonical_id: Optional[str]
416418

417419

420+
class DatasetRecord(DatasetRecordRaw, _DatasetRecordOptional):
421+
record_id: str
422+
423+
418424
class TaskResult(TypedDict):
419425
idx: int
420426
span_id: str

0 commit comments

Comments
 (0)