ci: pin test agent in hatch.toml#16652
ci: pin test agent in hatch.toml#16652gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
Codeowners resolved as |
|
/merge -f --reason "this is blocking the remainder of the repo" |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
thomas.kowalski@datadoghq.com unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
Performance SLOsComparing candidate florentin.labelle/pin-test-agent-in-hatch.toml (257e5a8) with baseline main (de513d6) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 102.900µs (SLO: <130.000µs 📉 -20.8%) vs baseline: +0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.1% ✅ add_inplace_aspectTime: ✅ 100.825µs (SLO: <130.000µs 📉 -22.4%) vs baseline: -2.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 28.434µs (SLO: <40.000µs 📉 -28.9%) vs baseline: +1.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.4% ✅ add_noaspectTime: ✅ 49.143µs (SLO: <70.000µs 📉 -29.8%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ bytearray_aspectTime: ✅ 250.412µs (SLO: <400.000µs 📉 -37.4%) vs baseline: +1.6% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 635.846µs (SLO: <800.000µs 📉 -20.5%) vs baseline: -3.0% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 264.029µs (SLO: <400.000µs 📉 -34.0%) vs baseline: -3.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 136.185µs (SLO: <300.000µs 📉 -54.6%) vs baseline: -3.1% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ bytes_aspectTime: ✅ 215.887µs (SLO: <300.000µs 📉 -28.0%) vs baseline: -1.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytes_noaspectTime: ✅ 134.394µs (SLO: <200.000µs 📉 -32.8%) vs baseline: -0.7% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 3.785ms (SLO: <5.000ms 📉 -24.3%) vs baseline: -0.3% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 315.694µs (SLO: <420.000µs 📉 -24.8%) vs baseline: -0.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 89.697µs (SLO: <300.000µs 📉 -70.1%) vs baseline: +0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 252.140µs (SLO: <300.000µs 📉 -16.0%) vs baseline: -0.2% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ casefold_aspectTime: ✅ 93.282µs (SLO: <500.000µs 📉 -81.3%) vs baseline: +4.8% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ casefold_noaspectTime: ✅ 309.308µs (SLO: <500.000µs 📉 -38.1%) vs baseline: +0.6% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ decode_aspectTime: ✅ 87.109µs (SLO: <100.000µs 📉 -12.9%) vs baseline: +0.5% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 153.799µs (SLO: <210.000µs 📉 -26.8%) vs baseline: -0.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 83.967µs (SLO: <200.000µs 📉 -58.0%) vs baseline: -0.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ encode_noaspectTime: ✅ 139.727µs (SLO: <200.000µs 📉 -30.1%) vs baseline: -2.3% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ format_aspectTime: ✅ 14.596ms (SLO: <19.200ms 📉 -24.0%) vs baseline: -0.2% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.4% ✅ format_map_aspectTime: ✅ 16.396ms (SLO: <21.500ms 📉 -23.7%) vs baseline: -0.6% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 370.150µs (SLO: <500.000µs 📉 -26.0%) vs baseline: -2.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ format_noaspectTime: ✅ 302.920µs (SLO: <500.000µs 📉 -39.4%) vs baseline: -1.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ index_aspectTime: ✅ 120.845µs (SLO: <300.000µs 📉 -59.7%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ index_noaspectTime: ✅ 40.256µs (SLO: <300.000µs 📉 -86.6%) vs baseline: -0.2% Memory: ✅ 42.841MB (SLO: <46.000MB -6.9%) vs baseline: +4.2% ✅ join_aspectTime: ✅ 208.900µs (SLO: <300.000µs 📉 -30.4%) vs baseline: -3.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 142.959µs (SLO: <300.000µs 📉 -52.3%) vs baseline: -0.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 494.736µs (SLO: <700.000µs 📉 -29.3%) vs baseline: -3.0% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ ljust_noaspectTime: ✅ 258.382µs (SLO: <300.000µs 📉 -13.9%) vs baseline: -1.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 294.166µs (SLO: <500.000µs 📉 -41.2%) vs baseline: -2.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ lower_noaspectTime: ✅ 234.618µs (SLO: <300.000µs 📉 -21.8%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 0.268ms (SLO: <3.000ms 📉 -91.1%) vs baseline: -3.8% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.1% ✅ lstrip_noaspectTime: ✅ 0.211ms (SLO: <3.000ms 📉 -93.0%) vs baseline: 📈 +18.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 14.671ms (SLO: <18.750ms 📉 -21.8%) vs baseline: +2.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.785ms (SLO: <19.350ms 📉 -23.6%) vs baseline: -0.2% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 14.379ms (SLO: <18.900ms 📉 -23.9%) vs baseline: -0.2% Memory: ✅ 43.185MB (SLO: <46.000MB -6.1%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.647ms (SLO: <19.150ms 📉 -23.5%) vs baseline: +0.6% Memory: ✅ 43.087MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.365ms (SLO: <3.000ms 📉 -87.8%) vs baseline: +0.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 18.416ms (SLO: <24.000ms 📉 -23.3%) vs baseline: +0.3% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% ✅ replace_noaspectTime: ✅ 280.461µs (SLO: <300.000µs -6.5%) vs baseline: -0.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 311.609µs (SLO: <420.000µs 📉 -25.8%) vs baseline: -3.3% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 47.126µs (SLO: <90.000µs 📉 -47.6%) vs baseline: +0.9% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ rstrip_aspectTime: ✅ 381.558µs (SLO: <500.000µs 📉 -23.7%) vs baseline: -0.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 184.602µs (SLO: <300.000µs 📉 -38.5%) vs baseline: +1.5% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 183.121µs (SLO: <300.000µs 📉 -39.0%) vs baseline: +1.0% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ slice_noaspectTime: ✅ 54.069µs (SLO: <90.000µs 📉 -39.9%) vs baseline: -0.6% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.0% ✅ stringio_aspectTime: ✅ 3.833ms (SLO: <5.000ms 📉 -23.3%) vs baseline: -0.6% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 382.749µs (SLO: <500.000µs 📉 -23.5%) vs baseline: +8.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 266.827µs (SLO: <350.000µs 📉 -23.8%) vs baseline: -3.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 175.961µs (SLO: <240.000µs 📉 -26.7%) vs baseline: -0.3% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 331.293µs (SLO: <500.000µs 📉 -33.7%) vs baseline: -2.8% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 270.745µs (SLO: <400.000µs 📉 -32.3%) vs baseline: -1.1% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 317.575µs (SLO: <500.000µs 📉 -36.5%) vs baseline: -4.7% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ title_noaspectTime: ✅ 257.691µs (SLO: <400.000µs 📉 -35.6%) vs baseline: -1.6% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ translate_aspectTime: ✅ 488.723µs (SLO: <700.000µs 📉 -30.2%) vs baseline: -1.6% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 424.111µs (SLO: <500.000µs 📉 -15.2%) vs baseline: -1.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ upper_aspectTime: ✅ 294.784µs (SLO: <500.000µs 📉 -41.0%) vs baseline: -2.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 236.026µs (SLO: <400.000µs 📉 -41.0%) vs baseline: -1.0% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 508.992µs (SLO: <700.000µs 📉 -27.3%) vs baseline: 📈 +18.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.4% ✅ ospathbasename_noaspectTime: ✅ 427.710µs (SLO: <700.000µs 📉 -38.9%) vs baseline: -1.1% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 627.956µs (SLO: <700.000µs 📉 -10.3%) vs baseline: +0.8% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 631.134µs (SLO: <700.000µs -9.8%) vs baseline: -0.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 347.383µs (SLO: <700.000µs 📉 -50.4%) vs baseline: -1.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 357.756µs (SLO: <700.000µs 📉 -48.9%) vs baseline: -0.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 488.679µs (SLO: <700.000µs 📉 -30.2%) vs baseline: -1.5% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 497.762µs (SLO: <700.000µs 📉 -28.9%) vs baseline: +0.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 373.481µs (SLO: <700.000µs 📉 -46.6%) vs baseline: +1.3% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 74.081µs (SLO: <700.000µs 📉 -89.4%) vs baseline: +2.0% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.4% ✅ ospathsplitext_aspectTime: ✅ 458.174µs (SLO: <700.000µs 📉 -34.5%) vs baseline: +0.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 465.839µs (SLO: <700.000µs 📉 -33.5%) vs baseline: ~same Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.389ms (SLO: <32.950ms -4.7%) vs baseline: ~same Memory: ✅ 36.726MB (SLO: <39.250MB -6.4%) vs baseline: +4.5% ✅ mediumTime: ✅ 3.116ms (SLO: <3.200ms -2.6%) vs baseline: +0.6% Memory: ✅ 35.507MB (SLO: <38.750MB -8.4%) vs baseline: +4.1% ✅ smallTime: ✅ 366.207µs (SLO: <370.000µs 🟡 -1.0%) vs baseline: +4.6% Memory: ✅ 35.645MB (SLO: <38.750MB -8.0%) vs baseline: +4.7%
|
|
/merge -f --reason "unblock main that is red because of this issue" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: unblock main that is red because of this issue |
a6dfd8e
into
main
## Description Pin test agent to version `1.42.0` to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279 ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes The CI actually uses `1.36.0` but it adds `wrapt` as a transitive depdency that breaks the current type checking. <!-- Any other information that would be helpful for reviewers --> Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com> (cherry picked from commit a6dfd8e)
Backport a6dfd8e from #16652 to 4.5. ## Description Pin test agent to version `1.42.0` to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279 ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes The CI actually uses `1.36.0` but it adds `wrapt` as a transitive depdency that breaks the current type checking. <!-- Any other information that would be helpful for reviewers --> Co-authored-by: florentinl <florentin.labelle@datadoghq.com> Co-authored-by: brett.langdon <brett.langdon@datadoghq.com>
Description
Pin test agent to version
1.42.0to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279Testing
Risks
Additional Notes
The CI actually uses
1.36.0but it addswraptas a transitive depdency that breaks the current type checking.