Skip to content

feat: validate and sort meta.events JSON encoded values#279

Merged
Kyle-Verhoog merged 4 commits intomasterfrom
brettlangdon/sorting.span.events
Feb 23, 2026
Merged

feat: validate and sort meta.events JSON encoded values#279
Kyle-Verhoog merged 4 commits intomasterfrom
brettlangdon/sorting.span.events

Conversation

@brettlangdon
Copy link
Member

  1. Add a check to ensure the value is a valid JSON array
  2. Add sorting to the payload parsing and snapshot generation to help any tracers whose hashmap key encoding is not sorted/deterministic

1. Add a check to ensure the value is a valid JSON array
2. Add sorting to the payload parsing and snapshot generation to help any tracers whose hashmap key encoding is not sorted/deterministic
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release note and then lgtm

@brettlangdon
Copy link
Member Author

release note and then lgtm

@Kyle-Verhoog done, release note added

@Kyle-Verhoog Kyle-Verhoog merged commit ed87387 into master Feb 23, 2026
18 checks passed
@Kyle-Verhoog Kyle-Verhoog deleted the brettlangdon/sorting.span.events branch February 23, 2026 08:12
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Feb 25, 2026
## Description

Pin test agent to version `1.42.0` to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks -->

## Additional Notes

The CI actually uses `1.36.0` but it adds `wrapt` as a transitive depdency that breaks the current type checking.

<!-- Any other information that would be helpful for reviewers -->


Co-authored-by: thomas.kowalski <[email protected]>
gnufede pushed a commit to DataDog/dd-trace-py that referenced this pull request Mar 4, 2026
## Description

Pin test agent to version `1.42.0` to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks -->

## Additional Notes

The CI actually uses `1.36.0` but it adds `wrapt` as a transitive depdency that breaks the current type checking.

<!-- Any other information that would be helpful for reviewers -->

Co-authored-by: thomas.kowalski <[email protected]>
(cherry picked from commit a6dfd8e)
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/dd-trace-py that referenced this pull request Mar 4, 2026
Backport a6dfd8e from #16652 to 4.5.

## Description

Pin test agent to version `1.42.0` to avoid the breaking change introduced in DataDog/dd-apm-test-agent#279

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks -->

## Additional Notes

The CI actually uses `1.36.0` but it adds `wrapt` as a transitive depdency that breaks the current type checking.

<!-- Any other information that would be helpful for reviewers -->


Co-authored-by: florentinl <[email protected]>
Co-authored-by: brett.langdon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants