-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update compute_stats_by_span_kind documentation #23945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compute_stats_by_span_kind documentation #23945
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=30550328 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 48580cb9-dc70-4c16-896b-87ada22cdc9e Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +2.58 | [-3.73, +8.89] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +2.58 | [-3.73, +8.89] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | +2.30 | [-2.63, +7.23] |
| ➖ | idle | memory utilization | +1.27 | [+1.23, +1.31] |
| ➖ | basic_py_check | % cpu utilization | +0.84 | [-1.59, +3.26] |
| ➖ | trace_agent_json | ingress throughput | +0.03 | [-0.02, +0.07] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.02, +0.01] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.04 | [-0.47, +0.40] |
| ➖ | file_tree | memory utilization | -0.23 | [-0.34, -0.13] |
| ➖ | process_agent_standard_check | memory utilization | -0.35 | [-0.40, -0.31] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.43 | [-0.48, -0.39] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.46 | [-0.55, -0.37] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.63 | [-0.68, -0.59] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.62 | [-4.34, +1.10] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions!
Co-authored-by: May Lee <[email protected]>
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue Added to the queue. There are 2 builds ahead of this PR! (estimated merge in less than 28m) Use |
This reverts commit 21bf096.
* Edit docs and release note with clarification * Update release note * Apply suggestions from code review Co-authored-by: May Lee <[email protected]> --------- Co-authored-by: May Lee <[email protected]>
What does this PR do?
Updates documentation for compute_stats_by_span_kind based on changes from #22163. Also adds clarification in previous release note to address similar config options.
Motivation
Clarification on top-level spans update.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes