Skip to content

Commit 3b821bf

Browse files
liustanleymaycmlee
andauthored
Apply suggestions from code review
Co-authored-by: May Lee <[email protected]>
1 parent 53e52aa commit 3b821bf

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/config/config_template.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1553,8 +1553,8 @@ api_key:
15531553
## @env DD_APM_COMPUTE_STATS_BY_SPAN_KIND - bool - default: false
15541554
## [BETA] Enables an additional stats computation check on spans to see they have an eligible `span.kind` (server, consumer, client, producer).
15551555
## If enabled, a span with an eligible `span.kind` will have stats computed. If disabled, only top-level and measured spans will have stats computed.
1556-
## NOTE: Stats are now computed by span kind for OTel traces by default.
1557-
## If you are sending OTel traces and do not want stats computed by span kind, this flag will need to be disabled and the "disable_otlp_compute_top_level_by_span_kind" APM Feature will need to be enabled.
1556+
## NOTE: Stats are computed by span kind for OTel traces by default.
1557+
## If you are sending OTel traces and do not want stats computed by span kind, you need to disable this flag and enable the "disable_otlp_compute_top_level_by_span_kind" APM feature.
15581558
# compute_stats_by_span_kind: false
15591559

15601560
## @param peer_service_aggregation - bool - default: false

releasenotes/notes/otel-top-level-spans-3e391e77dd7ebf83.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ features:
1111
OTLP ingest now identifies top-level spans by span kind for OpenTelemetry spans by default. This is both a breaking change and a bug fix that may increase the number of spans that generate trace metrics. This new logic can be disabled if needed by adding `disable_otlp_compute_top_level_by_span_kind` in DD_APM_FEATURES.
1212
- With this new logic, root spans and spans with a server or consumer `span.kind` will be marked as top-level. Additionally, spans with a client or producer `span.kind` will have stats computed.
1313
- If `disable_otlp_compute_top_level_by_span_kind` is enabled, this new logic will be disabled and OpenTelemetry spans may be misidentified as top-level.
14-
- Please note that in order to disable computing stats by span kind for OTel traces, `disable_otlp_compute_top_level_by_span_kind` needs to be enabled and `apm_config.compute_stats_by_span_kind` needs to be disabled.
14+
- To disable computing stats by span kind for OTel traces, enable `disable_otlp_compute_top_level_by_span_kind` and disable `apm_config.compute_stats_by_span_kind`.

0 commit comments

Comments
 (0)