Skip to content

Rework hotkey support #5654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab9rf merged 21 commits into from
Dec 6, 2025
+781 −425
Merged

Rework hotkey support #5654

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
207e443
Refactor hotkey code into a new Hotkey module
NicksWorld Nov 20, 2025
1554b55
Reorder imports
NicksWorld Nov 20, 2025
ec2b309
Move keybinding command handling into Hotkey module
NicksWorld Nov 20, 2025
3c2dc3c
Properly populate the command field on keybinds
NicksWorld Nov 20, 2025
b5d8899
Lua api for hotkeys and library support for future keybinding gui
NicksWorld Nov 20, 2025
74737b4
Prefer using to typedef
NicksWorld Nov 20, 2025
1fcee14
Improve keybinding command error messages for invalid keyspecs
NicksWorld Nov 20, 2025
e49d220
Make keyspecs case-insensitive (excluding focus strings)
NicksWorld Nov 20, 2025
43ecdad
Address code review concerns
NicksWorld Nov 21, 2025
2ee9d7e
Initial documentation pass, and improvements to lua api ergonomics
NicksWorld Nov 21, 2025
7ce44a5
Improve api ergonomics and add missing locks
NicksWorld Nov 23, 2025
68e0d5b
First pass at changelog
NicksWorld Nov 23, 2025
9c87028
Allow "Super" as a hotkey modifier
NicksWorld Nov 23, 2025
05f6440
Add heuristic method to catch potentially disruptive keybinds
NicksWorld Nov 23, 2025
b89d747
Cleanup pass
NicksWorld Nov 25, 2025
f0e98b5
Address tidy checks
NicksWorld Nov 25, 2025
f65e4bd
Remove redundant lock causing deadlock when listing keybinds
NicksWorld Dec 4, 2025
32bd846
Merge branch 'develop' into refactor/hotkey_module
NicksWorld Dec 4, 2025
0e341b7
Relocate keybinding command handling
NicksWorld Dec 4, 2025
c080015
Merge branch 'develop' into refactor/hotkey_module
ab9rf Dec 6, 2025
bfee603
Merge branch 'develop' into refactor/hotkey_module
ab9rf Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ set(MODULE_HEADERS
include/modules/Graphic.h
include/modules/Gui.h
include/modules/GuiHooks.h
include/modules/Hotkey.h
include/modules/Items.h
include/modules/Job.h
include/modules/Kitchen.h
Expand Down Expand Up @@ -186,6 +187,7 @@ set(MODULE_SOURCES
modules/Filesystem.cpp
modules/Graphic.cpp
modules/Gui.cpp
modules/Hotkey.cpp
modules/Items.cpp
modules/Job.cpp
modules/Kitchen.cpp
Expand Down
Loading
Loading