-
Notifications
You must be signed in to change notification settings - Fork 489
Rework hotkey support #5654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NicksWorld
wants to merge
16
commits into
DFHack:develop
Choose a base branch
from
NicksWorld:refactor/hotkey_module
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework hotkey support #5654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab79524 to
b5d8899
Compare
ab9rf
reviewed
Nov 20, 2025
Contributor
|
Lua API should make it easier to test most of the hotkey surface. |
ab9rf
reviewed
Nov 20, 2025
ab9rf
reviewed
Nov 20, 2025
dhthwy
reviewed
Nov 20, 2025
8a8ac10 to
43ecdad
Compare
1ab8893 to
68e0d5b
Compare
00fb481 to
b89d747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the hotkey support currently present in Core into a separate module for all related functionality. A number major changes/additions have been made during my rework: