Skip to content

Conversation

@shaikhu
Copy link
Contributor

@shaikhu shaikhu commented Jun 23, 2024

According to the docs, since v1.5 the Tools format has been deprecated and a new format recommended. While the entity Metada has been updated to use the new format (new method setToolChoice), Vulnerability has not. This PR adds a similar method to Vulnerability.

@shaikhu shaikhu marked this pull request as ready for review June 24, 2024 07:10
@shaikhu shaikhu requested a review from a team as a code owner June 24, 2024 07:10
@nscuro
Copy link
Member

nscuro commented Jun 24, 2024

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

@nscuro nscuro added the enhancement New feature or request label Jun 24, 2024
@shaikhu
Copy link
Contributor Author

shaikhu commented Jun 25, 2024

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

I signed-off my commits, but it looks like my email address was incorrect in my local git configt! I've since corrected it and signed-off the commits again, however DCO is still complaining about the previous/invalid email. I'll close this PR and raise another. Sorry for the hassle.

@shaikhu shaikhu closed this Jun 25, 2024
@shaikhu
Copy link
Contributor Author

shaikhu commented Jun 25, 2024

Thanks for the PR @shaikhu. Can you please sign-off your commits to make the DCO check happy? You can find instructions on how to do that by clicking on the Details link next to the failing build check.

I signed-off my commits, but it looks like my email address was incorrect! I've since corrected it and signed-off the commits, however DCO is complaining about the previous/invalid email. I'll close this and raise another PR. Sorry for the hassle.

New PR found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants